Skip to content
Snippets Groups Projects
Commit 31f436ae authored by Moritz Strohm's avatar Moritz Strohm Committed by David Siegfried
Browse files

fixed accessibility issues when assigning courses to a colour group

parent 203eb5a9
No related branches found
No related tags found
No related merge requests found
...@@ -58,11 +58,14 @@ ...@@ -58,11 +58,14 @@
<? for ($i = 0; $i < 9; $i++): ?> <? for ($i = 0; $i < 9; $i++): ?>
<td class="gruppe<?= $i ?> mycourses-group-selector" onclick="this.querySelector('input').checked = true;"> <td class="gruppe<?= $i ?> mycourses-group-selector" onclick="this.querySelector('input').checked = true;">
<input type="radio" name="gruppe[<?= $member['seminar_id'] ?>]" value="<?= $i ?>" <input type="radio" name="gruppe[<?= $member['seminar_id'] ?>]" value="<?= $i ?>"
aria-label="<?= _('Zugeordnet zu Gruppe ') . ($i + 1) ?>" aria-label="<?= sprintf(_('Gruppe %u zuordnen'), ($i + 1)) ?>"
id="course-group-<?= htmlReady($member['seminar_id']) ?>-<?= $i ?>" id="course-group-<?= htmlReady($member['seminar_id']) ?>-<?= $i ?>"
<? if ($my_sem[$member['seminar_id']]['gruppe'] == $i) echo 'checked'; ?>> <? if ($my_sem[$member['seminar_id']]['gruppe'] == $i) echo 'checked'; ?>>
<label for="course-group-<?= htmlReady($member['seminar_id']) ?>-<?= $i ?>"> <label for="course-group-<?= htmlReady($member['seminar_id']) ?>-<?= $i ?>">
<?= sprintf(_('Gruppe %u zuordnen'), $i + 1) ?> <span class="group-number"><?= $i + 1 ?></span>
<span class="checked-icon">
<?= Icon::create('accept', in_array($i, [3,4,5,7]) ? Icon::ROLE_INFO : Icon::ROLE_INFO_ALT)->asImg(20) ?>
</span>
</label> </label>
</td> </td>
<? endfor; ?> <? endfor; ?>
......
...@@ -9,7 +9,7 @@ ...@@ -9,7 +9,7 @@
background: var(--white); background: var(--white);
} }
.mycourses-group-selector { form.default .mycourses-group-selector {
position: relative; position: relative;
background-clip: padding-box; background-clip: padding-box;
...@@ -19,16 +19,32 @@ ...@@ -19,16 +19,32 @@
@extend .sr-only; @extend .sr-only;
&:checked + label { &:checked + label {
@include background-icon(accept, info); .group-number {
display: none;
}
.checked-icon {
display: inline;
}
} }
} }
&:hover label { &:hover label {
@include background-icon(accept, info); .group-number {
display: none;
}
.checked-icon {
display: inline;
}
} }
label { label {
@include hide-text(); /*@include hide-text();*/
text-indent: 0;
text-align: center;
font-size: large;
font-weight: bold;
margin-top: 0.5ex;
position: absolute; position: absolute;
top: 0; top: 0;
...@@ -40,5 +56,16 @@ ...@@ -40,5 +56,16 @@
background-repeat: no-repeat; background-repeat: no-repeat;
cursor: pointer; cursor: pointer;
.group-number {
display: inline;
}
.checked-icon {
display: none;
}
} }
} }
.mycourses-group-selector:not(.gruppe3, .gruppe4, .gruppe5, .gruppe7) {
color: $white;
}
...@@ -277,7 +277,8 @@ if ($navigation) { ...@@ -277,7 +277,8 @@ if ($navigation) {
<? $membership = CourseMember::find([Context::get()->id, $GLOBALS['user']->id]) ?> <? $membership = CourseMember::find([Context::get()->id, $GLOBALS['user']->id]) ?>
<? if ($membership) : ?> <? if ($membership) : ?>
<a href="<?= URLHelper::getLink('dispatch.php/my_courses/groups') ?>" <a href="<?= URLHelper::getLink('dispatch.php/my_courses/groups') ?>"
data-dialog data-dialog aria-label="<?= _('Gruppenzuordnung der Veranstaltung ändern') ?>"
title="<?= _('Gruppenzuordnung der Veranstaltung ändern') ?>"
class="colorblock gruppe<?= $membership ? $membership['gruppe'] : 1 ?>"></a> class="colorblock gruppe<?= $membership ? $membership['gruppe'] : 1 ?>"></a>
<? endif ?> <? endif ?>
<? endif ?> <? endif ?>
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment