Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
Stud.IP
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Iterations
Wiki
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Locked files
Deploy
Model registry
Analyze
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
Uni Osnabrück
Stud.IP
Commits
31f436ae
Commit
31f436ae
authored
11 months ago
by
Moritz Strohm
Committed by
David Siegfried
10 months ago
Browse files
Options
Downloads
Patches
Plain Diff
fixed accessibility issues when assigning courses to a colour group
parent
203eb5a9
No related branches found
No related tags found
No related merge requests found
Changes
3
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
app/views/my_courses/groups.php
+5
-2
5 additions, 2 deletions
app/views/my_courses/groups.php
resources/assets/stylesheets/scss/my_courses.scss
+31
-4
31 additions, 4 deletions
resources/assets/stylesheets/scss/my_courses.scss
templates/header.php
+2
-1
2 additions, 1 deletion
templates/header.php
with
38 additions
and
7 deletions
app/views/my_courses/groups.php
+
5
−
2
View file @
31f436ae
...
...
@@ -58,11 +58,14 @@
<?
for
(
$i
=
0
;
$i
<
9
;
$i
++
)
:
?>
<td
class=
"gruppe
<?=
$i
?>
mycourses-group-selector"
onclick=
"this.querySelector('input').checked = true;"
>
<input
type=
"radio"
name=
"gruppe[
<?=
$member
[
'seminar_id'
]
?>
]"
value=
"
<?=
$i
?>
"
aria-label=
"
<?=
_
(
'Zugeordnet zu Gruppe '
)
.
(
$i
+
1
)
?>
"
aria-label=
"
<?=
sprintf
(
_
(
'Gruppe %u zuordnen'
),
(
$i
+
1
)
)
?>
"
id=
"course-group-
<?=
htmlReady
(
$member
[
'seminar_id'
])
?>
-
<?=
$i
?>
"
<?
if
(
$my_sem
[
$member
[
'seminar_id'
]][
'gruppe'
]
==
$i
)
echo
'checked'
;
?>
>
<label
for=
"course-group-
<?=
htmlReady
(
$member
[
'seminar_id'
])
?>
-
<?=
$i
?>
"
>
<?=
sprintf
(
_
(
'Gruppe %u zuordnen'
),
$i
+
1
)
?>
<span
class=
"group-number"
>
<?=
$i
+
1
?>
</span>
<span
class=
"checked-icon"
>
<?=
Icon
::
create
(
'accept'
,
in_array
(
$i
,
[
3
,
4
,
5
,
7
])
?
Icon
::
ROLE_INFO
:
Icon
::
ROLE_INFO_ALT
)
->
asImg
(
20
)
?>
</span>
</label>
</td>
<?
endfor
;
?>
...
...
This diff is collapsed.
Click to expand it.
resources/assets/stylesheets/scss/my_courses.scss
+
31
−
4
View file @
31f436ae
...
...
@@ -9,7 +9,7 @@
background
:
var
(
--
white
);
}
.mycourses-group-selector
{
form
.default
.mycourses-group-selector
{
position
:
relative
;
background-clip
:
padding-box
;
...
...
@@ -19,16 +19,32 @@
@extend
.sr-only
;
&
:checked
+
label
{
@include
background-icon
(
accept
,
info
);
.group-number
{
display
:
none
;
}
.checked-icon
{
display
:
inline
;
}
}
}
&
:hover
label
{
@include
background-icon
(
accept
,
info
);
.group-number
{
display
:
none
;
}
.checked-icon
{
display
:
inline
;
}
}
label
{
@include
hide-text
();
/*@include hide-text();*/
text-indent
:
0
;
text-align
:
center
;
font-size
:
large
;
font-weight
:
bold
;
margin-top
:
0
.5ex
;
position
:
absolute
;
top
:
0
;
...
...
@@ -40,5 +56,16 @@
background-repeat
:
no-repeat
;
cursor
:
pointer
;
.group-number
{
display
:
inline
;
}
.checked-icon
{
display
:
none
;
}
}
}
.mycourses-group-selector
:not
(
.gruppe3
,
.gruppe4
,
.gruppe5
,
.gruppe7
)
{
color
:
$white
;
}
This diff is collapsed.
Click to expand it.
templates/header.php
+
2
−
1
View file @
31f436ae
...
...
@@ -277,7 +277,8 @@ if ($navigation) {
<?
$membership
=
CourseMember
::
find
([
Context
::
get
()
->
id
,
$GLOBALS
[
'user'
]
->
id
])
?>
<?
if
(
$membership
)
:
?>
<a
href=
"
<?=
URLHelper
::
getLink
(
'dispatch.php/my_courses/groups'
)
?>
"
data-dialog
data-dialog
aria-label=
"
<?=
_
(
'Gruppenzuordnung der Veranstaltung ändern'
)
?>
"
title=
"
<?=
_
(
'Gruppenzuordnung der Veranstaltung ändern'
)
?>
"
class=
"colorblock gruppe
<?=
$membership
?
$membership
[
'gruppe'
]
:
1
?>
"
></a>
<?
endif
?>
<?
endif
?>
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment