check if the user needs booking rights on the resource, fixes #2570

Closes #2570

Merge request studip/studip!2159

lib/models/resources/ResourceBooking.class.php

@@ -485,11 +485,21 @@ class ResourceBooking extends SimpleORMap implements PrivacyObject, Studip\Calen
             $this->booking_user = User::findCurrent();
         }
 
+        $derived_resource = $this->resource->getDerivedClassInstance();
+
+        // check if the user needs booking rights on the resource
+        if (
+            $this->isFieldDirty('resource_id')
+            || $this->isFieldDirty('repetition_interval')
+            || $this->begin < $this->getPristineValue('begin')
+            || $this->end > $this->getPristineValue('end')
+            || $this->preparation_time > $this->getPristineValue('preparation_time')
+            || $this->repeat_end > $this->getPristineValue('repeat_end')
+        ) {
+
             //Check if the user has booking rights on the resource.
             //The user must have either permanent permissions or they have to
             //have booking rights by a temporary permission in this moment
-        //(the moment this booking is saved).
-        $derived_resource = $this->resource->getDerivedClassInstance();
             $user_has_booking_rights = $derived_resource->userHasBookingRights(
                 $this->booking_user, $this->begin, $this->end
             );
@@ -501,6 +511,7 @@ class ResourceBooking extends SimpleORMap implements PrivacyObject, Studip\Calen
                     )
                 );
             }
+        }
 
         $time_intervals = $this->calculateTimeIntervals(true);
         $time_interval_overlaps = [];