prevent more php warnings

views/exercises/cloze_exercise/solve.php

@@ -23,7 +23,7 @@
                 </select><!--
             <? else: ?>
              --><input type="text" class="character_input cloze_input" name="answer[<?= $blank ?>]"
-                       style="width: <?= $exercise->getInputWidth($blank) ?>em;" value="<?= htmlReady($response[$blank]) ?>"><!--
+                       style="width: <?= $exercise->getInputWidth($blank) ?>em;" value="<?= htmlReady(isset($response[$blank]) ? $response[$blank] : '') ?>"><!--
             <? endif ?>
         <? endif ?>
     <? endforeach ?>

views/exercises/tb_exercise/correct.php

@@ -21,7 +21,7 @@
         </ul>
 
         <div id="commented-<?= $exercise->id ?>">
-            <? if ($!empty(edit_solution)): ?>
+            <? if (!empty($edit_solution)): ?>
                 <? if ($exercise->getLayout() === 'markup'): ?>
                     <? $answer = $response[0] ?>
                 <? elseif ($exercise->getLayout() === 'code'): ?>
@@ -66,7 +66,7 @@
                 <? endif ?>
             </div>
 
-            <? if ($edit_solution): ?>
+            <? if (!empty($edit_solution)): ?>
                 <?= Studip\Button::create(_vips('Lösung bearbeiten'), 'edit_solution', ['class' => 'edit_solution']) ?>
 
                 <? if ($exercise->getLayout() === 'code'): ?>

views/exercises/tb_exercise/solve.php

 <? if ($exercise->getLayout() !== 'none'): ?>
-    <? if ($exercise->task['template'] != ''): ?>
+    <? if (!empty($exercise->task['template'])): ?>
         <div class="vips_tabs">
             <ul>
                 <li>
@@ -20,7 +20,7 @@
 
             <? /* student answer */ ?>
             <div id="solution-<?= $exercise->id ?>">
-                <? $answer = isset($response) ? $response[0] : $exercise->task['template'] ?>
+                <? $answer = isset($response) ? $response[0] : (isset($exercise->task['template']) ? $exercise->task['template'] : '') ?>
                 <? if ($exercise->getLayout() === 'markup'): ?>
                     <textarea name="answer[0]" class="character_input size-l wysiwyg" data-editor="removePlugins=studip-quote,studip-upload,ImageUpload" rows="20"><?= wysiwygReady($answer) ?></textarea>
                 <? elseif ($exercise->getLayout() === 'code'): ?>
@@ -35,7 +35,7 @@
                 <? endif ?>
             </div>
 
-    <? if ($exercise->task['template'] == ''): ?>
+    <? if (empty($exercise->task['template'])): ?>
         </label>
     <? else: ?>
             <? /* default answer */ ?>