clean up orphaned entries, fixes #75 and #77

migrations/007_cleanup_timesheets.php

+<?php
+
+class CleanupTimesheets extends Migration
+{
+    public function description()
+    {
+        return 'remove orphaned entries from stundenzettel_timesheets';
+    }
+
+    public function up()
+    {
+        $db = DBManager::get();
+
+        $sql = 'ALTER TABLE stundenzettel_contracts ADD KEY inst_id (inst_id)';
+        $db->exec($sql);
+
+        $sql = 'ALTER TABLE stundenzettel_timesheets ADD KEY contract_id (contract_id)';
+        $db->exec($sql);
+
+        $sql = 'DELETE FROM stundenzettel_timesheets
+                WHERE contract_id NOT IN (SELECT id FROM stundenzettel_contracts)';
+        $db->exec($sql);
+
+        $sql = 'DELETE FROM stundenzettel_records
+                WHERE timesheet_id NOT IN (SELECT id FROM stundenzettel_timesheets)';
+        $db->exec($sql);
+    }
+
+    public function down()
+    {
+        $db = DBManager::get();
+
+        $sql = 'ALTER TABLE stundenzettel_contracts DROP KEY inst_id';
+        $db->exec($sql);
+
+        $sql = 'ALTER TABLE stundenzettel_timesheets DROP KEY contract_id';
+        $db->exec($sql);
+    }
+}

models/StundenzettelContract.class.php

@@ -36,6 +36,12 @@ class StundenzettelContract extends \SimpleORMap
             'foreign_key' => 'inst_id'
         ];
 
+        $config['has_many']['timesheets'] = [
+            'class_name'        => 'StundenzettelTimesheet',
+            'assoc_foreign_key' => 'contract_id',
+            'on_delete'         => 'delete'
+        ];
+
         $config['additional_fields']['default_workday_time']['get'] = function ($item) {
             $workday_hours = $item->contract_hours / 4.348 / 5;
             $hours = floor($workday_hours);

models/StundenzettelRecord.class.php

@@ -26,7 +26,8 @@ class StundenzettelRecord extends \SimpleORMap
 
         $config['belongs_to']['timesheet'] = [
             'class_name'  => 'StundenzettelTimesheet',
-            'foreign_key' => 'timesheet_id',];
+            'foreign_key' => 'timesheet_id'
+        ];
 
         $config['registered_callbacks']['before_store'][] = 'before_store';
 

models/StundenzettelTimesheet.class.php

@@ -29,6 +29,12 @@ class StundenzettelTimesheet extends \SimpleORMap
             'foreign_key' => 'approver_id'
         ];
 
+        $config['has_many']['records'] = [
+            'class_name'        => 'StundenzettelRecord',
+            'assoc_foreign_key' => 'timesheet_id',
+            'on_delete'         => 'delete'
+        ];
+
         $config['additional_fields']['timesheet_balance']['get'] = function ($item) {
             if ($item->month_completed) {
                 return $item->sum - ($item->contract->contract_hours * 3600);