cleanup

MensaPlugin.class.php

@@ -4,8 +4,6 @@
  * @author  David Siegfried <david.siegfried@uni-vechta.de>
  * @license GPL2 or any later version
  */
-
-
 StudipAutoloader::addAutoloadPath(__DIR__ . '/classes');
 
 class MensaPlugin extends StudIPPlugin implements PortalPlugin
@@ -173,7 +171,7 @@ class MensaPlugin extends StudIPPlugin implements PortalPlugin
         $navigation = [];
 
         $nav = new Navigation('');
-        $nav->setURL(URLHelper::getLink($GLOBALS['ABSOLUTE_URI_STUDIP'],
+        $nav->setURL(URLHelper::getURL($GLOBALS['ABSOLUTE_URI_STUDIP'],
             ['mensa-widget' => ['date' => strtotime('yesterday', $date)]]));
         $nav->setImage(
             Icon::create(
@@ -185,7 +183,7 @@ class MensaPlugin extends StudIPPlugin implements PortalPlugin
         $navigation[] = $nav;
 
         $nav = new Navigation('');
-        $nav->setURL(URLHelper::getLink($GLOBALS['ABSOLUTE_URI_STUDIP'],
+        $nav->setURL(URLHelper::getURL($GLOBALS['ABSOLUTE_URI_STUDIP'],
             ['mensa-widget' => ['date' => strtotime('tomorrow', $date)]]));
         $nav->setImage(
             Icon::create(

migrations/01_add_cronjob.php

@@ -14,22 +14,21 @@ class AddCronjob extends Migration
 
     public function up()
     {
-        $task_id  = CronjobScheduler::registerTask($this->getCronjobFilename());
-        $schedule = CronjobScheduler::schedulePeriodic($task_id, 0, 0, 2);
 
+        if (CronjobTask::countByClass(MensaCronjob::class)) {
+            $task_id = CronjobScheduler::registerTask(new MensaCronjob());
+            $schedule = CronjobScheduler::schedulePeriodic($task_id, 0, 0, 2);
             $schedule->active = true;
             $schedule->store();
         }
+    }
 
     public function down()
     {
-        $task = reset(CronjobTask::findByClass('MensaCronjob'));
+        $task = CronjobTask::findOneBySQL(MensaCronjob::class);
+        if($task) {
             CronjobScheduler::unregisterTask($task->task_id);
         }
-    
-    private function getCronjobFilename()
-    {
-        return str_replace($GLOBALS['STUDIP_BASE_PATH'] . '/', '',
-            realpath(__DIR__ . '/../classes/MensaCronjob.class.php'));
     }
+
 }
\ No newline at end of file

plugin.manifest

 pluginclassname=MensaPlugin
 pluginname=Mensa
 origin=Vec
-version=2.1
+version=2.2
 studipMinVersion=4.0
+studipMaxVersion=5.9.99
 description=Zeigt den Mensaplan als Widget aber auch als Gesamtübersicht an
 displayname = Studentenwerk OS Mensaplan
 descriptionshort = Studentenwerk OS Mensaplandarstellung