remove description fields from semester_data and termine, closes #2483

Closes #2483

Merge request studip/studip!1675

app/controllers/admin/semester.php

@@ -75,7 +75,6 @@ class Admin_SemesterController extends AuthenticatedController
 
             // Extract values
             $this->semester->name           = Request::i18n('name');
-            $this->semester->description    = Request::i18n('description');
             $this->semester->semester_token = Request::i18n('token');
             $this->semester->beginn         = $this->getTimeStamp('beginn');
             $this->semester->ende           = $this->getTimeStamp('ende', '23:59:59');

app/routes/Semester.php

@@ -105,7 +105,6 @@ class Semester extends \RESTAPI\RouteMap
             'id'             => $semester['semester_id'],
             'title'          => (string) $semester['name'],
             'token'          => (string) $semester['semester_token'],
-            'description'    => (string) $semester['description'],
             'begin'          => (int) $semester['beginn'],
             'end'            => (int) $semester['ende'],
             'seminars_begin' => (int) $semester['vorles_beginn'],

app/views/admin/semester/edit.php

@@ -29,14 +29,6 @@
             ]) ?>
         </label>
 
-        <label>
-            <?= _('Beschreibung') ?>
-
-            <?= I18N::textarea('description', $semester->description, [
-                'id' => 'description',
-            ]) ?>
-        </label>
-
         <label>
             <?= _('Externe ID') ?>
 

app/views/admin/semester/index.php

@@ -60,7 +60,7 @@
                     <? endif; ?>
                 >
             </td>
-            <td title="<?= htmlReady($semester->description) ?>">
+            <td>
                 <?= htmlReady($semester->name) ?>
                 <? if (!$semester->visible): ?>
                 <?= '(' . _('gesperrt') . ')'; ?>

db/migrations/5.4.2_remove_description_fields.php

+<?php
+final class RemoveDescriptionFields extends Migration
+{
+    public function description()
+    {
+        return 'Removes the unused database columns `termine`.`description`, `ex_termine`.`description` and `semester_data`.`description`';
+    }
+
+    protected function up()
+    {
+        $query = "ALTER TABLE `termine`
+                  DROP COLUMN `description`";
+        DBManager::get()->exec($query);
+        $query = "ALTER TABLE `ex_termine`
+                  DROP COLUMN `description`";
+        DBManager::get()->exec($query);
+        $query = "ALTER TABLE `semester_data`
+                  DROP COLUMN `description`";
+        DBManager::get()->exec($query);
+    }
+
+    protected function down()
+    {
+        $query = "ALTER TABLE `termine`
+                  ADD COLUMN `description` TEXT AFTER `content`";
+        DBManager::get()->exec($query);
+        $query = "ALTER TABLE `ex_termine`
+                  ADD COLUMN `description` TEXT AFTER `content`";
+        DBManager::get()->exec($query);
+        $query = "ALTER TABLE `semester_data`
+                  ADD COLUMN `description` TEXT NOT NULL AFTER `name`";
+        DBManager::get()->exec($query);
+    }
+}

lib/classes/JsonApi/Schemas/Semester.php

@@ -17,7 +17,6 @@ class Semester extends SchemaProvider
     {
         return [
             'title' => (string) $semester->name,
-            'description' => (string) $semester->description,
             'token' => (string) $semester->token,
             'start' => date('c', $semester->beginn),
             'end' => date('c', $semester->ende),

lib/models/CourseDate.class.php

@@ -15,7 +15,6 @@
  * @property string range_id database column
  * @property string autor_id database column
  * @property string content database column
- * @property string description database column
  * @property string date database column
  * @property string end_time database column
  * @property string mkdate database column

lib/models/CourseExDate.class.php

@@ -15,7 +15,6 @@
  * @property string range_id database column
  * @property string autor_id database column
  * @property string content database column
- * @property string description database column
  * @property string date database column
  * @property string end_time database column
  * @property string mkdate database column

lib/models/Semester.class.php

@@ -16,7 +16,6 @@
  * @property string semester_id database column
  * @property string id alias column for semester_id
  * @property string name database column
- * @property string description database column
  * @property string semester_token database column
  * @property string beginn database column
  * @property string ende database column
@@ -64,7 +63,6 @@ class Semester extends SimpleORMap
         $config['registered_callbacks']['after_delete'][] = 'refreshCache';
 
         $config['i18n_fields']['name'] = true;
-        $config['i18n_fields']['description'] = true;
         $config['i18n_fields']['semester_token'] = true;
 
         parent::configure($config);