Skip to content
Snippets Groups Projects
Commit eb48c488 authored by David Siegfried's avatar David Siegfried Committed by Jan-Hendrik Willms
Browse files

prevent php-warnings in members-list, fixes #4663

Closes #4663

Merge request studip/studip!3473
parent 844f18c6
No related branches found
No related tags found
No related merge requests found
...@@ -672,7 +672,7 @@ class Course_MembersController extends AuthenticatedController ...@@ -672,7 +672,7 @@ class Course_MembersController extends AuthenticatedController
foreach ($csv_lines as $csv_line) { foreach ($csv_lines as $csv_line) {
$csv_name = preg_split('/[,\t]/', mb_substr($csv_line, 0, 100), -1, PREG_SPLIT_NO_EMPTY); $csv_name = preg_split('/[,\t]/', mb_substr($csv_line, 0, 100), -1, PREG_SPLIT_NO_EMPTY);
$csv_nachname = trim($csv_name[0]); $csv_nachname = trim($csv_name[0]);
$csv_vorname = trim($csv_name[1]); $csv_vorname = trim($csv_name[1] ?? '');
if (!$csv_nachname) { if (!$csv_nachname) {
continue; continue;
...@@ -751,7 +751,7 @@ class Course_MembersController extends AuthenticatedController ...@@ -751,7 +751,7 @@ class Course_MembersController extends AuthenticatedController
// no results // no results
if (empty($csv_lines) && empty($selected_users)) { if (empty($csv_lines) && empty($selected_users)) {
PageLayout::postError(_("Niemanden gefunden!")); PageLayout::postError(_('Niemanden gefunden!'));
} }
if ($csv_count_insert) { if ($csv_count_insert) {
...@@ -1228,6 +1228,7 @@ class Course_MembersController extends AuthenticatedController ...@@ -1228,6 +1228,7 @@ class Course_MembersController extends AuthenticatedController
throw new AccessDeniedException(); throw new AccessDeniedException();
} }
$users = [];
// create a usable array // create a usable array
if(!empty($this->flash['users'])) { if(!empty($this->flash['users'])) {
foreach ($this->flash['users'] as $user => $val) { foreach ($this->flash['users'] as $user => $val) {
...@@ -1282,7 +1283,7 @@ class Course_MembersController extends AuthenticatedController ...@@ -1282,7 +1283,7 @@ class Course_MembersController extends AuthenticatedController
if ($next_status !== 'user' && !$this->is_dozent) { if ($next_status !== 'user' && !$this->is_dozent) {
throw new AccessDeniedException(); throw new AccessDeniedException();
} }
$users = [];
if (!empty($this->flash['users'])) { if (!empty($this->flash['users'])) {
foreach ($this->flash['users'] as $user => $val) { foreach ($this->flash['users'] as $user => $val) {
if ($val) { if ($val) {
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment