allow optional use of semester index in SemesterSelector, fixes #685

app/views/admin/autoinsert/_search.php

@@ -7,7 +7,8 @@
         <?= Semester::getSemesterSelector(
             ['name' => 'sem_select', 'id' => 'sem_select', 'class' => 'user_form'],
             $sem_select, 'semester_id',
-            true
+            true,
+            false
         )?>
     </label>
     <label>

lib/models/Semester.class.php

@@ -233,13 +233,16 @@ class Semester extends SimpleORMap
      * @param integer $default
      * @param string $option_value
      * @param boolean $include_all
+     * @param boolean $use_semester_id
      * @return string
      */
     public static function getSemesterSelector(
         $select_attributes = null,
         $default = 0,
         $option_value = 'semester_id',
-        $include_all = true)
+        $include_all = true,
+        $use_semester_id = true
+    )
     {
         $semester = Semester::findAllVisible();
 
@@ -262,6 +265,7 @@ class Semester extends SimpleORMap
         $template->select_attributes = $select_attributes;
         $template->default = $default;
         $template->option_value = $option_value;
+        $template->use_semester_id = $use_semester_id;
         return $template->render();
     }
 

templates/shared/semester-selector.php

@@ -4,7 +4,7 @@
 <select <?= $attributes ?>>
     <? foreach ($semesters as $sem_key => $one_sem) : ?>
         <? $one_sem['key'] = $sem_key; ?>
-        <option value="<?= $one_sem[$option_value] ?>" <?= ($one_sem[$option_value] == $default ? "selected" : "") ?>>
+        <option value="<?= $use_semester_id ? $one_sem[$option_value] : $sem_key ?>" <?= ($one_sem[$option_value] == $default ? "selected" : "") ?>>
             <?= htmlReady($one_sem['name']) ?>
         </option>
     <? endforeach ?>