align open groups config for my courses and notifications, fixes #328

app/controllers/settings/notification.php

@@ -180,8 +180,10 @@ class Settings_NotificationController extends Settings_SettingsController
      */
     public function open_action($id)
     {
-        $open      = $this->config->MY_COURSES_OPEN_GROUPS;
-        $open[$id] = true;
+        $open = $this->config->MY_COURSES_OPEN_GROUPS;
+        if (!in_array($id, $open)) {
+            $open[] = $id;
+        }
         $this->config->store('MY_COURSES_OPEN_GROUPS', $open);
 
         $this->redirect('settings/notification');
@@ -195,7 +197,7 @@ class Settings_NotificationController extends Settings_SettingsController
     public function close_action($id)
     {
         $open = $this->config->MY_COURSES_OPEN_GROUPS;
-        unset($open[$id]);
+        $open = array_diff($open, [$id]);
         $this->config->store('MY_COURSES_OPEN_GROUPS', $open);
 
         $this->redirect('settings/notification');

db/migrations/5.1.4_fix_my_courses_group_config.php

+<?php
+final class FixMyCoursesGroupConfig extends Migration
+{
+    public function up()
+    {
+        ConfigValue::findEachBySQL(
+            function ($value) {
+                $groups = json_decode($value->value, true);
+
+                $changed = false;
+                foreach ($groups as $index => $val) {
+                    if ($val === true) {
+                        unset($groups[$index]);
+                        $groups[] = $index;
+
+                        $changed = true;
+                    }
+                }
+
+                if ($changed) {
+                    $value->value = json_encode($groups);
+                    $value->store();
+                }
+            },
+            'field = ?',
+            ['MY_COURSES_OPEN_GROUPS']
+        );
+    }
+}