fix notice about only passing variables by reference, fixes #4472

Closes #4472

Merge request studip/studip!3260

app/views/fachabschluss/abschluesse/index.php

@@ -60,7 +60,7 @@
                         $pagination->set_attribute('perPage', MVVController::$items_per_page);
                         $pagination->set_attribute('num_postings', $count);
                         $pagination->set_attribute('page', $page);
-                        $page_link = reset(explode('?', $controller->action_url('index'))) . '?page_abschluesse=%s';
+                        $page_link = explode('?', $controller->action_url('index'))[0] . '?page_abschluesse=%s';
                         $pagination->set_attribute('pagelink', $page_link);
                         echo $pagination->render();
                     ?>

app/views/fachabschluss/faecher/index.php

@@ -61,7 +61,7 @@
                         $pagination->set_attribute('perPage', MVVController::$items_per_page);
                         $pagination->set_attribute('num_postings', $count);
                         $pagination->set_attribute('page', $page);
-                        $page_link = reset(explode('?', $controller->action_url('index'))) . '?page_faecher=%s';
+                        $page_link = explode('?', $controller->action_url('index'))[0] . '?page_faecher=%s';
                         $pagination->set_attribute('pagelink', $page_link);
                         echo $pagination->render();
                         ?>

app/views/lvgruppen/lvgruppen/index.php

@@ -89,7 +89,7 @@
                     $pagination->set_attribute('perPage', MVVController::$items_per_page);
                     $pagination->set_attribute('num_postings', $count);
                     $pagination->set_attribute('page', $page);
-                    $page_link = reset(explode('?', $controller->action_url('index'))) . '?page_lvgruppen=%s';
+                    $page_link = explode('?', $controller->action_url('index'))[0] . '?page_lvgruppen=%s';
                     $pagination->set_attribute('pagelink', $page_link);
                     echo $pagination->render();
                     ?>

app/views/module/module/index.php

@@ -27,7 +27,7 @@
                     $pagination->set_attribute('perPage', MVVController::$items_per_page);
                     $pagination->set_attribute('num_postings', $count);
                     $pagination->set_attribute('page', $page);
-                    $page_link = reset(explode('?', $controller->action_url('index'))) . '?page_module=%s';
+                    $page_link = explode('?', $controller->action_url('index'))[0] . '?page_module=%s';
                     $pagination->set_attribute('pagelink', $page_link);
                     echo $pagination->render();
                     ?>

app/views/search/module/index.php

@@ -51,7 +51,7 @@
                     $pagination->set_attribute('perPage', MVVController::$items_per_page);
                     $pagination->set_attribute('num_postings', $count);
                     $pagination->set_attribute('page', $page);
-                    $page_link = reset(explode('?', $controller->action_url('index'))) . '?page_module=%s';
+                    $page_link = explode('?', $controller->action_url('index'))[0] . '?page_module=%s';
                     $pagination->set_attribute('pagelink', $page_link);
                     echo $pagination->render();
                 ?>

app/views/shared/contacts/index.php

@@ -82,7 +82,7 @@
                     $pagination->set_attribute('perPage', MVVController::$items_per_page);
                     $pagination->set_attribute('num_postings', $count);
                     $pagination->set_attribute('page', $page);
-                    $page_link = reset(explode('?', $controller->action_url('index'))) . '?page_contacts=%s';
+                    $page_link = explode('?', $controller->action_url('index'))[0] . '?page_contacts=%s';
                     $pagination->set_attribute('pagelink', $page_link);
                     echo $pagination->render();
                     ?>