group roles in administration, fixes #1793

Closes #1793

Merge request studip/studip!1173

app/controllers/admin/role.php

@@ -177,7 +177,7 @@ class Admin_RoleController extends AuthenticatedController
             $this->currentuser = $this->users[$usersel];
             $this->assignedroles = $this->currentuser->getRoles();
             $this->all_userroles = $this->currentuser->getRoles(true);
-            $this->roles = RolePersistence::getAllRoles();
+            $this->roles = RolePersistence::getAllRoles(true);
             foreach ($this->assignedroles as $role) {
                 $institutes = SimpleCollection::createFromArray(Institute::findMany(RolePersistence::getAssignedRoleInstitutes($usersel, $role->getRoleid())));
                 $this->assignedroles_institutes[$role->getRoleid()] = $institutes->orderBy('name')->pluck('name');
@@ -227,7 +227,7 @@ class Admin_RoleController extends AuthenticatedController
 
         $this->plugins = PluginManager::getInstance()->getPluginInfos();
         $this->assigned = RolePersistence::getAssignedPluginRoles($pluginid);
-        $this->roles = RolePersistence::getAllRoles();
+        $this->roles = RolePersistence::getAllRoles(true);
         $this->pluginid = $pluginid;
     }
 

app/views/admin/role/assign_plugin_role.php

@@ -63,12 +63,22 @@ use Studip\Button;
                 </td>
                 <td>
                     <select multiple name="rolesel[]" size="10" style="width: 300px;">
-                        <? foreach ($roles as $role): ?>
-                            <option value="<?= $role->getRoleid() ?>">
-                                <?= htmlReady($role->getRolename()) ?>
-                                <? if ($role->getSystemtype()): ?>[<?= _('Systemrolle') ?>]<? endif ?>
-                            </option>
-                        <? endforeach ?>
+                        <optgroup label="<?= _('Systemrollen') ?>">
+                            <? foreach ($roles['system'] as $role): ?>
+                                <option value="<?= $role->getRoleid() ?>">
+                                    <?= htmlReady($role->getRolename()) ?>
+                                </option>
+                            <? endforeach ?>
+                        </optgroup>
+                    <? if (count($roles['other']) > 0): ?>
+                        <optgroup label="<?= _('Weitere Rollen') ?>">
+                            <? foreach ($roles['other'] as $role): ?>
+                                <option value="<?= $role->getRoleid() ?>">
+                                    <?= htmlReady($role->getRolename()) ?>
+                                </option>
+                            <? endforeach ?>
+                        </optgroup>
+                    <? endif; ?>
                     </select>
                 </td>
             </tr>

app/views/admin/role/assign_role.php

@@ -82,12 +82,22 @@ use Studip\Button, Studip\LinkButton;
                 </td>
                 <td>
                     <select size="10" name="rolesel[]" multiple style="width: 300px;">
-                        <? foreach ($roles as $role): ?>
+                        <optgroup label="<?= _('Systemrollen') ?>">
+                        <? foreach ($roles['system'] as $role): ?>
                             <option value="<?= $role->getRoleid() ?>">
                                 <?= htmlReady($role->getRolename()) ?>
-                                <? if ($role->getSystemtype()): ?>[<?= _('Systemrolle') ?>]<? endif ?>
                             </option>
                         <? endforeach ?>
+                        </optgroup>
+                    <? if (count($roles['other']) > 0): ?>
+                        <optgroup label="<?= _('Weitere Rollen') ?>">
+                        <? foreach ($roles['other'] as $role): ?>
+                            <option value="<?= $role->getRoleid() ?>">
+                                <?= htmlReady($role->getRolename()) ?>
+                            </option>
+                        <? endforeach ?>
+                        </optgroup>
+                    <? endif; ?>
                     </select>
                 </td>
             </tr>

lib/plugins/db/RolePersistence.class.php

@@ -22,7 +22,7 @@ class RolePersistence
      *
      * @return array Roles
      */
-    public static function getAllRoles(): array
+    public static function getAllRoles(bool $grouped = false): array
     {
         // read cache
         $cache = StudipCacheFactory::getCache();
@@ -44,7 +44,17 @@ class RolePersistence
             $cache->write(self::ROLES_CACHE_KEY, $roles);
         }
 
-        return $roles;
+        if (!$grouped) {
+            return $roles;
+        }
+
+        $groups = ['system' => [], 'other' => []];
+        foreach ($roles as $id => $role) {
+            $index = $role->getSystemtype() ? 'system' : 'other';
+            $groups[$index][$id] = $role;
+        }
+
+        return $groups;
     }
 
     public static function getRoleIdByName($name)