fixed error when deleting booking interval from a booking with repetitions, closes #704

Closes #704

Merge request studip/studip!886

app/views/resources/booking/_add_edit_form.php

@@ -561,9 +561,7 @@
                                         <? endif ?>
                                     </td>
                                     <td class="booking-list-interval-actions">
-                                        <a class="takes-place-delete takes-place-status-toggle
-                                <?= $interval->takes_place ? '' : ' invisible'; ?>
-                                "
+                                        <button class="takes-place-delete takes-place-status-toggle <?= $interval->takes_place ? '' : ' invisible'; ?>"
                                                 data-interval_id="<?= htmlReady($interval->id) ?>">
                                             <?= Icon::create('trash')->asImg(
                                                 [
@@ -571,11 +569,9 @@
                                                     'title' => _('löschen')
                                                 ]
                                             ) ?>
-                                        </a>
+                                        </button>
 
-                                        <a class="takes-place-revive takes-place-status-toggle
-                                <?= $interval->takes_place ? ' invisible' : ''; ?>
-                                "
+                                        <button class="takes-place-revive takes-place-status-toggle <?= $interval->takes_place ? ' invisible' : ''; ?>"
                                                 data-interval_id="<?= htmlReady($interval->id) ?>">
                                             <?= Icon::create('refresh')->asImg(
                                                 [
@@ -583,7 +579,7 @@
                                                     'title' => _('wiederherstellen')
                                                 ]
                                             ) ?>
-                                        </a>
+                                        </button>
                                     </td>
                                 </tr>
                             <? endforeach ?>

resources/assets/javascripts/bootstrap/resources.js

@@ -81,12 +81,6 @@ STUDIP.ready(function () {
         }
     }
 
-    jQuery(document).on(
-        'click',
-        '.booking-list-interval .takes-place-status-toggle',
-        STUDIP.Resources.toggleBookingIntervalStatus
-    );
-
     jQuery(document).on(
         'click',
         '.resource-category-properties-table .add-action',
@@ -879,6 +873,12 @@ STUDIP.ready(function () {
 
 
 STUDIP.domReady(function() {
+    jQuery(document).on(
+        'click',
+        '.booking-list-interval .takes-place-status-toggle',
+        STUDIP.Resources.toggleBookingIntervalStatus
+    );
+
     jQuery(document).on(
         'click',
         '.room-clipboard-group-action',

resources/assets/javascripts/lib/resources.js

@@ -485,6 +485,7 @@ class Resources
 
     static toggleBookingIntervalStatus(event)
     {
+        event.preventDefault();
         var li = jQuery(event.target).parents('tr')[0];
         if (!li) {
             //Something is wrong with the HTML.

resources/assets/stylesheets/scss/resources.scss

@@ -521,3 +521,9 @@ form#resolve-request, form#decline-request {
         padding-bottom: 10px;
     }
 }
+
+
+button.takes-place-status-toggle {
+    border: none;
+    background: none;
+}