prevent php8 warning by using the same underlying data, fixes #4948

Closes #4948

Merge request studip/studip!3713

app/controllers/settings/notification.php

@@ -89,8 +89,8 @@ class Settings_NotificationController extends Settings_SettingsController
                 'visible'        => $seminar['visible'],
                 'gruppe'         => $su->gruppe,
                 'sem_status'     => $seminar->status,
-                'sem_number'     => Semester::getIndexById($seminar->start_semester->id),
-                'sem_number_end' => Semester::getIndexById($seminar->end_semester->id ?? '') ?: '-1',
+                'sem_number'     => Semester::getIndexById($seminar->start_semester->id, true, true),
+                'sem_number_end' => Semester::getIndexById($seminar->end_semester->id ?? '', true, true) ?: '-1',
             ];
             if ($group_field) {
                 fill_groups($groups, Semester::getIndexById($seminar->start_semester->id), [

lib/classes/MyRealmModel.php

@@ -316,8 +316,8 @@ class MyRealmModel
             $_course['visitdate']      = $visits[$course->id][0]['visitdate'];
             $_course['user_status']    = $user_status;
             $_course['gruppe']         = !$is_deputy ? $member_ships[$course->id]['gruppe'] ?? null : ($deputy ? $deputy->gruppe : null);
-            $_course['sem_number_end'] = $course->isOpenEnded() ? $max_sem_key : Semester::getIndexById($course->end_semester->id);
-            $_course['sem_number']     = Semester::getIndexById($course->start_semester->id ?? null);
+            $_course['sem_number_end'] = $course->isOpenEnded() ? $max_sem_key : Semester::getIndexById($course->end_semester->id, true, true);
+            $_course['sem_number']     = Semester::getIndexById($course->start_semester->id ?? null, true, true);
             $_course['tools']          = $course->tools;
             $_course['name']           = $course->name;
             $_course['temp_name']      = $course->name;