use Request::int() for clipboard_id, fixes #4715

Closes #4715

Merge request !3535

app/controllers/resources/messages.php

@@ -68,7 +68,7 @@ class Resources_MessagesController extends AuthenticatedController
             $this->room_selection = Request::get('room_selection');
             $this->room_ids = Request::getArray('room_ids');
             $this->selected_rooms = Room::findMany($this->room_ids);
-            $this->clipboard_id = Request::get('clipboard_id');
+            $this->clipboard_id = Request::int('clipboard_id');
 
             //First validation:
 

app/controllers/resources/print.php

@@ -132,7 +132,7 @@ class Resources_PrintController extends AuthenticatedController
         //clipboard, the selected date and the selected schedule type.
         //Furthermore a date and the type of schedule has been selected.
         // Also check for booking types to export.
-        $this->selected_clipboard_id = Request::get('clipboard_id');
+        $this->selected_clipboard_id = Request::int('clipboard_id');
         $this->schedule_type = Request::get('schedule_type');
         $this->selected_date_string = Request::get('date');
         $this->selected_booking_types = Request::intArray('bookingtypes') ?:

app/controllers/resources/room_request.php

@@ -1302,7 +1302,7 @@ class Resources_RoomRequestController extends AuthenticatedController
 
         $this->clipboards = Clipboard::getClipboardsForUser($this->current_user->id, ['Room']);
 
-        $this->selected_clipboard_id = Request::get('selected_clipboard_id');
+        $this->selected_clipboard_id = Request::int('selected_clipboard_id');
         if (!$this->selected_clipboard_id) {
             if (count($this->clipboards) > 0) {
                 $this->selected_clipboard_id = $this->clipboards[0]->id;

app/controllers/room_management/planning.php

@@ -30,7 +30,7 @@ class RoomManagement_PlanningController extends AuthenticatedController
         if (Navigation::hasItem('/resources/planning/index')) {
             Navigation::activateItem('/resources/planning/index');
         }
-        $selected_clipboard_id = Request::get('clipboard_id', $selected_clipboard_id);
+        $selected_clipboard_id = Request::int('clipboard_id', $selected_clipboard_id);
 
         $this->no_clipboard = false;
         $this->no_rooms = false;
@@ -271,7 +271,7 @@ class RoomManagement_PlanningController extends AuthenticatedController
             Navigation::activateItem('/resources/planning/semestergroup_plan');
         }
 
-        $selected_clipboard_id = Request::get('clipboard_id', $selected_clipboard_id);
+        $selected_clipboard_id = Request::int('clipboard_id', $selected_clipboard_id);
 
         $this->no_clipboard = false;
         $this->no_rooms = false;
@@ -1066,7 +1066,7 @@ class RoomManagement_PlanningController extends AuthenticatedController
             Navigation::activateItem('/resources/planning/booking_comments');
         }
 
-        $selected_clipboard_id = Request::get('clipboard_id', $selected_clipboard_id);
+        $selected_clipboard_id = Request::int('clipboard_id', $selected_clipboard_id);
         $this->standalone = false;
 
         if ($selected_clipboard_id) {

lib/classes/sidebar/ClipboardWidget.php

@@ -84,7 +84,7 @@ class ClipboardWidget extends SidebarWidget
         if (Request::submitted('clipboard_update_session_special_action')) {
             CSRFProtection::verifyUnsafeRequest();
 
-            $_SESSION['selected_clipboard_id'] = Request::get('selected_clipboard_id');
+            $_SESSION['selected_clipboard_id'] = Request::int('selected_clipboard_id');
         }
     }