use reference

.gitlab-ci.yml

@@ -33,18 +33,18 @@ stages:
   - release
 
 .scripts:
-  mkdir-caches: &mkdir-caches
+  mkdir-caches:
     - mkdir -p $CACHE_DIR
-  mkdir-reports: &mkdir-reports
+  mkdir-reports:
     - mkdir -p $REPORT_DIR
-  install-composer: &install-composer
+  install-composer:
     - make composer-dev
-  configure-studip: &configure-studip
-    - *install-composer
+  configure-studip:
+    - !reference [.scripts, install-composer]
     - cp docker/studip/config_local.php config/config_local.inc.php
     - cp config/config.inc.php.dist config/config.inc.php
-  initialize-studip-database: &initialize-studip-database
-    - *configure-studip
+  initialize-studip-database:
+    - !reference [.scripts, configure-studip]
     - chmod +x .gitlab/scripts/install_db.sh
     - .gitlab/scripts/install_db.sh
     - cli/studip migrate
@@ -57,7 +57,7 @@ stages:
     paths:
       - composer/
     policy: pull
-  npm: &npm-cache
+  npm:
     key:
       files:
         - package-lock.json
@@ -65,7 +65,7 @@ stages:
       - .npm
 
 .definitions:
-  mariadb-service: &mariadb-service
+  mariadb-service:
    - name: mariadb
      command: [ "--sql_mode=","--character-set-client=utf8","--character-set-server=utf8","--collation-server=utf8_unicode_ci"]
   php-changed:
@@ -96,7 +96,7 @@ build-composer:
   script:
     - composer install
   cache:
-    - *composer-cache
+    - !reference [.caches, composer]
     - key: composer-package-cache
       paths:
         - $COMPOSER_CACHE
@@ -113,14 +113,14 @@ lint-php:
     PHPLINT_CODE_QUALITY_REPORT: $REPORT_DIR/phplint-codequality.json
   interruptible: true
   cache:
-    - *composer-cache
+    - !reference [.caches, composer]
     - key: "$CI_JOB_NAME_SLUG:$CI_COMMIT_REF_SLUG"
       paths:
         - $CACHE_LOCATION
   before_script:
-    - *mkdir-caches
-    - *mkdir-reports
-    - *install-composer
+    - !reference [.scripts, mkdir-caches]
+    - !reference [.scripts, mkdir-reports]
+    - !reference [.scripts, install-composer]
   script:
     - COMPOSER_MEMORY_LIMIT=-1
       composer exec phplint
@@ -145,14 +145,14 @@ lint-php-7.4:
     PHPLINT_CODE_QUALITY_REPORT: $REPORT_DIR/phplint-codequality-7.4.json
   interruptible: true
   cache:
-    - *composer-cache
+    - !reference [.caches, composer]
     - key: "$CI_JOB_NAME_SLUG:$CI_COMMIT_REF_SLUG"
       paths:
         - $CACHE_LOCATION
   before_script:
-    - *mkdir-caches
-    - *mkdir-reports
-    - *install-composer
+    - !reference [.scripts, mkdir-caches]
+    - !reference [.scripts, mkdir-reports]
+    - !reference [.scripts, install-composer]
   script:
     - COMPOSER_MEMORY_LIMIT=-1
       composer exec phplint
@@ -180,7 +180,7 @@ lint-js:
         - $CACHE_LOCATION
   interruptible: true
   before_script:
-    - *mkdir-reports
+    - !reference [.scripts, mkdir-reports]
     - npm install -g npm@7
     - npm install
       --no-save --no-audit --no-fund
@@ -211,7 +211,7 @@ lint-css:
       paths:
         - $CACHE_LOCATION
   before_script:
-    - *mkdir-reports
+    - !reference [.scripts, mkdir-reports]
     - npm install
       --no-save --no-audit --no-fund
       --loglevel=error 
@@ -239,14 +239,14 @@ phpstan:
   interruptible: true
   when: manual
   cache:
-   - *composer-cache
+   - !reference [.caches, composer]
    - key: "$CO_JOB_NAME_SLUG:$CI_COMMIT_REF_SLUG"
      paths:
        - $CACHE_LOCATION
   before_script:
-    - *mkdir-caches
-    - *mkdir-reports
-    - *install-composer
+    - !reference [.scripts, mkdir-caches]
+    - !reference [.scripts, mkdir-reports]
+    - !reference [.scripts, install-composer]
     - 'echo "includes:\n    - phpstan.neon.dist\n\nparameters:\n   tmpDir: $PHPSTAN_CACHE_PATH" > phpstan.neon'
   script:
     - php
@@ -274,8 +274,8 @@ test-unit:
   allow_failure: false
   interruptible: true
   before_script:
-    - *mkdir-reports
-    - *configure-studip
+    - !reference [.scripts, mkdir-reports]
+    - !reference [.scripts, configure-studip]
   script:
     - 'composer/bin/codecept
       run unit
@@ -295,10 +295,11 @@ test-jest:
   image: $NODE_IMAGE
   variables:
     JS_TEST_REPORT: $REPORT_DIR/jest.xml
-  cache: *npm-cache
+  cache:
+    - !reference [.caches, npm]
   interruptible: true
   before_script:
-    - *mkdir-reports
+    - !reference [.scripts, mkdir-reports]
     - npm install
   script:
     - JEST_JUNIT_OUTPUT_FILE="$JS_TEST_REPORT" npx jest tests/jest/ --ci --reporters=default --reporters=jest-junit
@@ -318,12 +319,12 @@ test-functional:
     <<: *composer-cache
     policy: pull
   services:
-    - *mariadb-service
+    - !reference [.definitions, mariadb-service]
   allow_failure: false
   interruptible: true
   before_script:
-    - *mkdir-reports
-    - *initialize-studip-database
+    - !reference [.scripts, mkdir-reports]
+    - !reference [.scripts, initialize-studip-database]
   script:
     - 'composer/bin/codecept
       run functional
@@ -344,13 +345,13 @@ test-jsonapi:
     <<: *composer-cache
     policy: pull
   services:
-    - *mariadb-service
+    - !reference [.definitions, mariadb-service]
   variables:
     JSONAPI_XML_REPORT: $REPORT_DIR/jsonapi-report.xml
   interruptible: true
   before_script:
-    - *mkdir-reports
-    - *initialize-studip-database
+    - !reference [.scripts, mkdir-reports]
+    - !reference [.scripts, initialize-studip-database]
   script:
     - 'composer/bin/codecept
       run jsonapi
@@ -370,7 +371,8 @@ test-assets:
     - !reference [.definitions, css-changed]
     -  when: manual
   image: $NODE_IMAGE
-  cache: *npm-cache
+  cache:
+    - !reference [.caches, npm]
   interruptible: true
   before_script:
     - npm install
@@ -390,8 +392,8 @@ test-e2e:
   interruptible: true
   when: manual
   cache:
-    - *composer-cache
-    - *npm-cache
+    - !reference [.caches, composer]
+    - !reference [.caches, npm]
   before_script:
     - mkdir ./bin
     - apt-get update
@@ -410,8 +412,8 @@ test-e2e:
     - php composer-setup.php  --install-dir=./bin --filename=composer
     - export PATH="./bin:$PATH"
     - php -r "unlink('composer-setup.php');"
-    - *mkdir-reports
-    - *initialize-studip-database
+    - !reference [.scripts, mkdir-reports]
+    - !reference [.scripts, initialize-studip-database]
     - ./cli/studip config:set SHOW_TERMS_ON_FIRST_LOGIN 0
     - npm install playwright
     - npm ci