Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
Stud.IP
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Wiki
Requirements
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Locked files
Build
Pipelines
Jobs
Pipeline schedules
Test cases
Artifacts
Deploy
Releases
Package Registry
Container Registry
Model registry
Operate
Environments
Terraform modules
Monitor
Incidents
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Code review analytics
Issue analytics
Insights
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
Jan-Hendrik Willms
Stud.IP
Commits
7b16d960
Commit
7b16d960
authored
2 years ago
by
André Noack
Browse files
Options
Downloads
Patches
Plain Diff
closes #844 re #377
parent
b7802baa
No related branches found
No related tags found
No related merge requests found
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
lib/models/Course.class.php
+8
-1
8 additions, 1 deletion
lib/models/Course.class.php
with
8 additions
and
1 deletion
lib/models/Course.class.php
+
8
−
1
View file @
7b16d960
...
...
@@ -311,12 +311,15 @@ class Course extends SimpleORMap implements Range, PrivacyObject, StudipItem, Fe
{
$end_semester
=
$this
->
semesters
->
last
();
$start_semester
=
$this
->
semesters
->
first
();
if
(
$start_semester
->
id
===
$semester
->
id
)
{
return
;
}
if
(
$end_semester
)
{
if
(
count
(
$this
->
semesters
)
>
1
&&
$end_semester
->
beginn
<
$semester
->
beginn
)
{
throw
new
InvalidArgumentException
(
'start-semester must start before end-semester'
);
}
foreach
(
$this
->
semesters
as
$key
=>
$one_semester
)
{
if
(
$one_semester
->
beginn
<
=
$semester
->
beginn
)
{
if
(
$one_semester
->
beginn
<
$semester
->
beginn
)
{
$this
->
semesters
->
offsetUnset
(
$key
);
}
}
...
...
@@ -334,7 +337,11 @@ class Course extends SimpleORMap implements Range, PrivacyObject, StudipItem, Fe
*/
public
function
setEndSemester
(
?Semester
$semester
)
{
$end_semester
=
$this
->
semesters
->
last
();
$start_semester
=
$this
->
semesters
->
first
();
if
((
is_null
(
$end_semester
)
&&
is_null
(
$semester
))
||
(
$end_semester
->
id
===
$semester
->
id
))
{
return
;
}
if
(
$start_semester
)
{
if
(
$semester
&&
$start_semester
->
beginn
>
$semester
->
beginn
)
{
throw
new
InvalidArgumentException
(
'end-semester must start after start-semester'
);
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment