fix js errors, fixes #968

Closes #968

Merge request !558

resources/assets/javascripts/bootstrap/actionmenu.js

-/*jslint esversion: 6 */
-
 (function ($) {
     'use strict';
 

resources/assets/javascripts/bootstrap/application.js

 import { $gettext } from '../lib/gettext.js';
 
-/*jslint browser: true, esversion: 6 */
-/*global window, $, jQuery, _ */
 /* ------------------------------------------------------------------------
  * application.js
  * This file is part of Stud.IP - http://www.studip.de
@@ -331,7 +329,7 @@ STUDIP.domReady(function () {
         } else {
             STUDIP.Scroll.removeHandler('horizontal-scroll');
         }
-    };
+    }
 
     if ($('.no-touch #layout_content').length > 0) {
         window.matchMedia('screen').addListener(function() {
@@ -348,7 +346,7 @@ jQuery(document).on('click', '.course-admin td .course-completion', function ()
     var href    = $(this).attr('href'),
         timeout = window.setTimeout(function () {
             $(this).addClass('ajaxing');
-        }.bind(this), 300);;
+        }.bind(this), 300);
 
     $.getJSON(href).done(function (completion) {
         clearTimeout(timeout);

resources/assets/javascripts/bootstrap/article.js

-/*jslint browser: true */
-/*global jQuery, STUDIP */
 (function ($, STUDIP) {
     'use strict';
 

resources/assets/javascripts/bootstrap/avatar.js

-/*global jQuery, STUDIP */
 STUDIP.domReady(() => {
     STUDIP.Avatar.init('#avatar-upload');
 

resources/assets/javascripts/bootstrap/blubber.js

-/*global jQuery, STUDIP */
 STUDIP.domReady(() => {
     STUDIP.Blubber.init();
 });

resources/assets/javascripts/bootstrap/cache-admin.js

@@ -7,7 +7,6 @@
  * @since     Stud.IP 5.0
  */
 
-/*global jQuery, STUDIP */
 import CacheAdministration from '../../../vue/components/CacheAdministration.vue'
 
 STUDIP.domReady(() => {

resources/assets/javascripts/bootstrap/copyable_links.js

 import { $gettext } from '../lib/gettext.js';
 
-/*jslint esversion: 6*/
 $(document).on('click', 'a.copyable-link', function (event) {
     event.preventDefault();
 

resources/assets/javascripts/bootstrap/files.js

-/*jslint esversion: 6 */
 function searchMoreFiles (button) {
     var table = $(button).closest('table');
     var loading = $('<div class="loading" style="padding: 10px">').html(
@@ -76,7 +75,7 @@ jQuery(document).on('ajaxComplete', (event, xhr) => {
     var payload = false;
 
     function process(key, handler) {
-        if (!changes.hasOwnProperty(key)) {
+        if (changes[key] === undefined) {
             return;
         }
 
@@ -86,10 +85,11 @@ jQuery(document).on('ajaxComplete', (event, xhr) => {
                 if (payload === false) {
                     payload = JSON.parse(xhr.responseText);
                 }
-                if (payload.hasOwnProperty(key)) {
+                if (payload[key] !== undefined) {
                     values = payload[key];
                 }
             } catch (e) {
+                console.log('Error parsing payload', e);
             }
         }
 

resources/assets/javascripts/bootstrap/forms.js

@@ -263,19 +263,7 @@ STUDIP.ready(function () {
     // class and attribute changes in order to detect when the select
     // element itself will become visible. Pretty straight forward, huh?
     $('select.nested-select:not(:has(optgroup)):hidden:not(.select2-awaiting)').each(function() {
-        var observer = new window.MutationObserver(function(mutations) {
-            mutations.forEach(function(mutation) {
-                if ($('select.select2-awaiting', mutation.target).length > 0) {
-                    $('select.select2-awaiting', mutation.target)
-                        .removeClass('select2-awaiting')
-                        .each(function() {
-                            createSelect2(this);
-                        });
-                    observer.disconnect();
-                    observer = null;
-                }
-            });
-        });
+        var observer = new window.MutationObserver(onDomChange);
         observer.observe($(this).closest(':visible')[0], {
             attributeOldValue: true,
             attributes: true,
@@ -288,6 +276,19 @@ STUDIP.ready(function () {
         $(this).addClass('select2-awaiting');
     });
 
+    function onDomChange(mutations, observer) {
+        mutations.forEach(function(mutation) {
+            if ($('select.select2-awaiting', mutation.target).length > 0) {
+                $('select.select2-awaiting', mutation.target)
+                    .removeClass('select2-awaiting')
+                    .each(function() {
+                        createSelect2(this);
+                    });
+                observer.disconnect();
+            }
+        });
+    }
+
     // Unfortunately, this code needs to be duplicated because jQuery
     // namespacing kind of sucks. If the below change handler is namespaced
     // and we trigger that namespaced event here, still all change handlers

resources/assets/javascripts/bootstrap/fullcalendar.js

-/*jslint esversion: 6*/
 STUDIP.ready(function () {
     //Check if fullcalendar instances are to be displayed:
     $('*[data-fullcalendar="1"]').each(function () {
@@ -11,18 +10,19 @@ STUDIP.ready(function () {
                     calendar = STUDIP.Fullcalendar.createFromNode(this);
                 }
 
-                let continuousRefresh = (ttl) => {
+                continuousRefresh(calendar, 10);
+            }
+        });
+    });
+
+    function continuousRefresh(calendar, ttl) {
         setTimeout(() => {
             calendar.updateSize();
             if (ttl > 0) {
                 continuousRefresh(ttl - 1);
             }
         }, 200);
-                };
-                continuousRefresh(10);
     }
-        });
-    });
 
     if ($('#event-color-picker > option').length <= 1) {
         var selectedColor = $('#selected-color').val();

resources/assets/javascripts/bootstrap/inline-editing.js

@@ -4,7 +4,7 @@ jQuery(
         jQuery(document).ready(
             function() {
                 var elements = jQuery('[data-inline-editing]');
-                for (element of elements) {
+                for (const element of elements) {
                     STUDIP.InlineEditing.init(element);
                 }
             }
@@ -15,7 +15,7 @@ jQuery(
             null,
             function() {
                 var elements = jQuery('.ui-dialog [data-inline-editing]');
-                for (element of elements) {
+                for (const element of elements) {
                     STUDIP.InlineEditing.init(element);
                 }
             }

resources/assets/javascripts/bootstrap/installer.js

-/*jslint esversion: 6*/
-
 function domReady(fn) {
     if (document.readyState === 'complete' || document.readyState === 'interactive') {
         setTimeout(fn, 1);

resources/assets/javascripts/bootstrap/mvv_difflog.js

@@ -14,6 +14,8 @@ STUDIP.domReady(() => {
             });
 
         if (mvv_field != '') {
+            var mvv_id;
+            var senddata;
             $(this)
                 .parentsUntil('div')
                 .each(function() {
@@ -31,9 +33,9 @@ STUDIP.domReady(() => {
                 var obj_elements = fields[i].split('.');
 
                 if (obj_elements.length == 1) {
-                    var senddata = { mvv_field: fields[i], mvv_debug: mvv_debug, log_action: 'del' };
+                    senddata = { mvv_field: fields[i], mvv_debug: mvv_debug, log_action: 'del' };
                 } else {
-                    var senddata = { mvv_field: fields[i], mvv_id: mvv_id, log_action: 'update' };
+                    senddata = { mvv_field: fields[i], mvv_id: mvv_id, log_action: 'update' };
                 }
 
                 var url = STUDIP.URLHelper.getURL('dispatch.php/shared/log_event/get_log_autor');
@@ -57,16 +59,17 @@ STUDIP.domReady(() => {
         var mvv_field = '';
         var mvv_coid = '';
         var mvv_id = '';
+        var mvv_log_action;
 
         switch ($('ins').attr('class')) {
             case 'diffins':
-                var mvv_log_action = 'new';
+                mvv_log_action = 'new';
                 break;
             case 'diffmod':
-                var mvv_log_action = 'update';
+                mvv_log_action = 'update';
                 break;
             default:
-                var mvv_log_action = null;
+                mvv_log_action = null;
                 break;
         }
 
@@ -93,9 +96,10 @@ STUDIP.domReady(() => {
             var ins = $(this);
             var fields = mvv_field.split(' ');
             for (var i = 0; i < fields.length; ++i) {
+                var senddata;
                 var obj_elements = fields[i].split('.');
                 if (obj_elements.length == 1 && mvv_coid) {
-                    var senddata = {
+                    senddata = {
                         mvv_field: fields[i],
                         mvv_id: mvv_id,
                         mvv_coid: mvv_coid,
@@ -113,7 +117,7 @@ STUDIP.domReady(() => {
                                 .attr('data-mvv-index') +
                             ';' +
                             classes[1];
-                        var senddata = {
+                        senddata = {
                             mvv_field: fields[i],
                             mvv_id: mvv_id,
                             mvv_coid: mvv_coid,
@@ -124,7 +128,7 @@ STUDIP.domReady(() => {
                         return true;
                     }
                 } else {
-                    var senddata = { mvv_field: fields[i], mvv_id: mvv_id, log_action: mvv_log_action };
+                    senddata = { mvv_field: fields[i], mvv_id: mvv_id, log_action: mvv_log_action };
                 }
 
                 var url = STUDIP.URLHelper.getURL('dispatch.php/shared/log_event/get_log_autor');
@@ -160,7 +164,10 @@ STUDIP.domReady(() => {
                 $.post(
                     url,
                     { mvv_field: 'mvv_' + mvv_type, mvv_id: mvv_id, log_action: 'new' },
-                    function(data) {
+                    onSuccess,
+                    'json'
+                );
+                function onSuccess((data) {
                     if (data) {
                         var info = $gettextInterpolate('Hinzugefügt von %{user} am %{time}', data);
                         curtable.attr('title', info);
@@ -169,9 +176,7 @@ STUDIP.domReady(() => {
                         const row = $('<tr/>').append(cell);
                         curtable.append(row);
                     }
-                    },
-                    'json'
-                );
+                };
             });
     });
 
@@ -191,7 +196,10 @@ STUDIP.domReady(() => {
                 $.post(
                     url,
                     { mvv_field: 'mvv_' + mvv_type, mvv_id: mvv_id, log_action: 'del' },
-                    function(data) {
+                    onSuccess,
+                    'json'
+                );
+                function onSuccess(data) {
                     if (data) {
                         var info = $gettextInterpolate('Entfernt von %{user} am %{time}', data);
                         curtable.attr('title', info);
@@ -200,9 +208,7 @@ STUDIP.domReady(() => {
                         const row = $('<tr/>').append(cell);
                         curtable.append(row);
                     }
-                    },
-                    'json'
-                );
+                }
             });
     });
 });

resources/assets/javascripts/bootstrap/raumzeit.js

@@ -47,27 +47,23 @@ $(document).on('click', '.bookable_rooms_action', function(event) {
                     .append(me.data('options').clone(true));
             }
 
-            if (
-                $(this)
-                    .parents('form')
-                    .attr('action')
-                    .split('saveDate/').length > 1
-            ) {
-                var singleDate = $(this)
+            let singleDate;
+            if ($(this).parents('form').attr('action').split('saveDate/').length > 1) {
+                singleDate = $(this)
                     .parents('form')
                     .attr('action')
                     .split('saveDate/')[1]
                     .split('?')[0];
-            } else {
-                var singleDate = undefined;
             }
+
+            let checked_dates;
             if ($("input[name='checked_dates']").length > 0) {
-                var checked_dates = $("input[name='checked_dates']")
+                checked_dates = $("input[name='checked_dates']")
                     .val()
                     .split(',');
                 var ndate = [];
             } else {
-                var checked_dates = [singleDate];
+                checked_dates = [singleDate];
                 var startDate = $("input[name='date']").val();
                 var start_time = $("input[name='start_time']")
                     .val()

resources/assets/javascripts/bootstrap/resources.js

@@ -86,8 +86,7 @@ STUDIP.ready(function () {
         //Check if the seats checkbox is checked. Only include "its" input
         //fields when it is checked.
         let seats_checked = jQuery(this).find('input[name="special__seats_enabled"]').is(':checked');
-        if (seats_checked) {
-        } else {
+        if (!seats_checked) {
             jQuery(this).find('input[name="special__seats_min"]').attr('disabled', 'disabled');
             jQuery(this).find('input[name="special__seats_max"]').attr('disabled', 'disabled');
         }
@@ -647,19 +646,13 @@ STUDIP.ready(function () {
         if (!changed) {
             sURLVariables.push('defaultView=' + defaultView);
         }
-        if (sURLVariables.length > 2) {
-            var newurl = sURLVariables[0] + '?' + sURLVariables[1] + '&';
-            sURLVariables.shift();
-            sURLVariables.shift();
-            newurl += sURLVariables.join('&');
-        } else {
-            var newurl = sURLVariables.join('?');
-        }
+
+        let newurl = `${sURLVariables[0]}?${sURLVariables.slice(1).join('&')}`;
         history.pushState({}, null, newurl);
         var std_day = newurl.replace(/&?allday=\d+/, '');
         $('.booking-plan-std_view').attr('href', std_day);
         $('.booking-plan-allday_view').attr('href', std_day + '&allday=1');
-    };
+    }
 
     function submitDatePicker() {
         var picked = $('#booking-plan-jmpdate').val();
@@ -727,14 +720,7 @@ STUDIP.ready(function () {
             if (!changed) {
                 sURLVariables.push('defaultDate=' + changeddate);
             }
-            if (sURLVariables.length > 2) {
-                var newurl = sURLVariables[0] + '?' + sURLVariables[1] + '&';
-                sURLVariables.shift();
-                sURLVariables.shift();
-                newurl += sURLVariables.join('&');
-            } else {
-                var newurl = sURLVariables.join('?');
-            }
+            let newurl = `${sURLVariables[0]}?${sURLVariables.slice(1).join('&')}`;
             history.pushState({}, null, newurl);
             var std_day = newurl.replace(/&?allday=\d+/, '');
             $('.booking-plan-std_view').attr('href', std_day);
@@ -743,7 +729,7 @@ STUDIP.ready(function () {
             //Store the date in the sessionStorage:
             sessionStorage.setItem('booking_plan_date', changeddate)
         }
-    };
+    }
 
     jQuery('#booking-plan-jmpdate').datepicker(
         {
@@ -757,8 +743,7 @@ STUDIP.ready(function () {
         }
     );
 
-    var nodes = jQuery('*.resource-plan[data-resources-fullcalendar="1"]');
-    jQuery.each(nodes, function (index, node) {
+    jQuery('*.resource-plan[data-resources-fullcalendar="1"]').each(function () {
         STUDIP.loadChunk('fullcalendar').then(() => {
             //Get the default date from the sessionStorage, if it is set
             //and no date is specified in the url.
@@ -770,10 +755,10 @@ STUDIP.ready(function () {
                     use_session_date = false;
                 }
             }
-            if (node.calendar == undefined) {
-                if (jQuery(node).hasClass('semester-plan')) {
+            if (this.calendar === undefined) {
+                if (jQuery(this).hasClass('semester-plan')) {
                     STUDIP.Fullcalendar.createSemesterCalendarFromNode(
-                        node,
+                        this,
                         {
                             loading: function (isLoading) {
                                 if (!isLoading) {
@@ -810,24 +795,20 @@ STUDIP.ready(function () {
                             config.defaultDate = session_date_string;
                         }
                     }
-                    STUDIP.Fullcalendar.createFromNode(node, config);
+                    STUDIP.Fullcalendar.createFromNode(this, config);
                 }
             }
         });
     });
 
     //Check if an individual booking plan is to be displayed:
-    var nodes = jQuery('.individual-booking-plan[data-resources-fullcalendar="1"]');
-    jQuery.each(nodes, function (index, node) {
+    jQuery('.individual-booking-plan[data-resources-fullcalendar="1"]').each(function () {
         STUDIP.loadChunk('fullcalendar').then(() => {
             STUDIP.Fullcalendar.createFromNode(
-                node,
+                this,
                 {
-                    eventPositioned: function (info, calendar_event, dom_element, view) {
-                        var calendar_event = info.event;
-                        var dom_element = info.el;
-                        var view = info.view;
-                        jQuery(dom_element).droppable({
+                    eventPositioned: function (info) {
+                        jQuery(info.el).droppable({
                             drop: function (event, ui_element) {
                                 event.preventDefault();
 

resources/assets/javascripts/bootstrap/responsive.js

-/*jslint esversion: 6*/
-
 // Build responsive menu on domready or resize
 STUDIP.domReady(() => {
     const cache = STUDIP.Cache.getInstance('responsive.');

resources/assets/javascripts/bootstrap/search.js

@@ -118,7 +118,7 @@ STUDIP.domReady(() => {
         history_timeout = setTimeout(() => {
             if (location.href !== url) {
                 history.pushState({
-                    needle: info.needle || STUDIP.Search.getCache().get('searchterm'),
+                    needle: info.needle || STUDIP.Search.getCache().get('searchterm'),
                     category: info.category
                 }, '', url)
             }

resources/assets/javascripts/bootstrap/sidebar.js

@@ -3,6 +3,14 @@ $(document).on('tourstart.studip tourend.studip', function(event) {
     STUDIP.Sidebar.setSticky(event.type === 'tourend.studip');
 });
 
+function heightChangeHandler() {
+    var curr_height = $(document).height();
+    if (doc_height !== curr_height) {
+        doc_height = curr_height;
+        $(document.body).trigger('sticky_kit:recalc');
+    }
+}
+
 // Handle dynamic content
 if (window.MutationObserver !== undefined) {
     // Attach mutation observer to #layout_content and trigger it on
@@ -31,14 +39,6 @@ if (window.MutationObserver !== undefined) {
     // Stores document height (we will need this to check for changes)
     var doc_height;
 
-    function heightChangeHandler() {
-        var curr_height = $(document).height();
-        if (doc_height !== curr_height) {
-            doc_height = curr_height;
-            $(document.body).trigger('sticky_kit:recalc');
-        }
-    }
-
     STUDIP.domReady(() => {
         doc_height = $(document).height();
     });

resources/assets/javascripts/bootstrap/statusgroups.js

-/*jslint esversion: 6*/
 STUDIP.ready(function() {
     STUDIP.Statusgroups.ajax_endpoint = $('meta[name="statusgroups-ajax-movable-endpoint"]').attr('content');
     STUDIP.Statusgroups.apply();

resources/assets/javascripts/bootstrap/studip_helper_attributes.js

@@ -185,8 +185,7 @@ function confirmation_handler(event) {
             // so that the original event can be executed
             element
                 .removeAttr('data-confirm')
-                .get(0)
-                [event.type]();
+                .get(0)[event.type]();
 
             // Reapply the data-confirm attribute
             window.setTimeout(function() {