change default value of configuration MY_INSTITUTES_DEFAULT to all, fixes #1656

Closes #1656

Merge request studip/studip!1067

app/controllers/admin/courses.php

@@ -291,10 +291,6 @@ class Admin_CoursesController extends AuthenticatedController
             PageLayout::postError(_('Sie wurden noch keiner Einrichtung zugeordnet'));
         }
 
-        if (!$GLOBALS['user']->cfg->MY_INSTITUTES_DEFAULT) {
-            $GLOBALS['user']->cfg->store('MY_INSTITUTES_DEFAULT', $this->insts[0]['Institut_id']);
-        }
-
         // Semester selection
         if ($GLOBALS['user']->cfg->MY_COURSES_SELECTED_CYCLE) {
             $this->semester = Semester::find($GLOBALS['user']->cfg->MY_COURSES_SELECTED_CYCLE);

db/migrations/5.1.35_set_configuration_my_institutes_default_to_all.php

+<?php
+
+/**
+ * @author Jan-Hendrik Willms <tleilax+studip@gmail.com>
+ * @license GPL2 or any later version
+ *
+ * @see https://develop.studip.de/trac/ticket/7058
+ * @see https://gitlab.studip.de/studip/studip/-/issues/1656
+ */
+final class SetConfigurationMyInstitutesDefaultToAll extends Migration
+{
+    public function description()
+    {
+        return 'Changes the default value of configuration MY_INSTITUTES_DEFAULT to "all"';
+    }
+
+    protected function up()
+    {
+        $query = "UPDATE `config`
+                  SET `value` = 'all'
+                  WHERE `field` = 'MY_INSTITUTES_DEFAULT'";
+        DBManager::get()->exec($query);
+    }
+}