Skip to content
Snippets Groups Projects
Commit 1654fc8f authored by David Siegfried's avatar David Siegfried
Browse files

prevent php-warnings, closes #2299 

Closes #2299

Merge request studip/studip!1520
parent c69e480c
No related branches found
No related tags found
1 merge request!4Draft: Icon creation
Hide whitespace changes
Inline Side-by-side
app/views/settings/statusgruppen/index.php
+ 15
− 15
View file @ 1654fc8f
...@@ -18,27 +18,27 @@ ...@@ -18,27 +18,27 @@
<nav> <nav>
<? if (!$locked && $inst_count > 0) : ?> <? if (!$locked && $inst_count > 0) : ?>
<a href="<?= $controller->url_for('settings/statusgruppen/move', $inst_id, 'up') ?>"> <a href="<?= $controller->url_for('settings/statusgruppen/move', $inst_id, 'up') ?>">
<?= Icon::create('arr_2up', 'sort')->asImg() ?> <?= Icon::create('arr_2up', Icon::ROLE_SORT) ?>
</a> </a>
<? elseif (!$locked && count($institutes) > 1): ?> <? elseif (!$locked && count($institutes) > 1): ?>
<?= Icon::create('arr_2up', 'inactive')->asImg() ?> <?= Icon::create('arr_2up', Icon::ROLE_INACTIVE) ?>
<? endif; ?> <? endif; ?>
<? if (!$locked && $inst_count + 1 < count($institutes)): ?> <? if (!$locked && $inst_count + 1 < count($institutes)): ?>
<a href="<?= $controller->url_for('settings/statusgruppen/move', $inst_id, 'down') ?>"> <a href="<?= $controller->url_for('settings/statusgruppen/move', $inst_id, 'down') ?>">
<?= Icon::create('arr_2down', 'sort')->asImg() ?> <?= Icon::create('arr_2down', Icon::ROLE_SORT) ?>
</a> </a>
<? elseif (!$locked && count($institutes) > 1): ?> <? elseif (!$locked && count($institutes) > 1): ?>
<?= Icon::create('arr_2down', 'inactive')->asImg() ?> <?= Icon::create('arr_2down', Icon::ROLE_INACTIVE) ?>
<? endif; ?> <? endif; ?>
<? if ($GLOBALS['perm']->have_studip_perm('admin', $inst_id)) : ?> <? if ($GLOBALS['perm']->have_studip_perm('admin', $inst_id)) : ?>
<a href="<?= URLHelper::getURL('dispatch.php/institute/members', ['cid' => $inst_id, 'admin_view' => 1]) ?>"> <a href="<?= URLHelper::getURL('dispatch.php/institute/members', ['cid' => $inst_id, 'admin_view' => 1]) ?>">
<?= Icon::create('link-intern', 'clickable', ['title' => _('Zur Einrichtung')])->asImg() ?> <?= Icon::create('link-intern')->asImg(['title' => _('Zur Einrichtung')]) ?>
</a> </a>
<? else: ?> <? else: ?>
<a href="<?= URLHelper::getURL('dispatch.php/institute/overview', ['auswahl' => $inst_id]) ?>"> <a href="<?= URLHelper::getURL('dispatch.php/institute/overview', ['auswahl' => $inst_id]) ?>">
<?= Icon::create('link-intern', 'clickable', ['title' => _('Zur Einrichtung')])->asImg() ?> <?= Icon::create('link-intern')->asImg(['title' => _('Zur Einrichtung')]) ?>
</a> </a>
<? endif; ?> <? endif; ?>
</nav> </nav>
...@@ -57,16 +57,16 @@ ...@@ -57,16 +57,16 @@
<? <?
$inst_count += 1; $inst_count += 1;
$role_count = 1; $role_count = 1;
$max_roles = count($institute['flattened']); $max_roles = isset($institute['flattened']) ? count($institute['flattened']) : 0;
?> ?>
<? foreach ($institute['flattened'] as $role_id => $role): ?> <? foreach ($institute['flattened'] as $role_id => $role): ?>
<article class="indented <?= ContentBoxHelper::classes($role_id) ?> <? if (Request::get('type') === 'role' && Request::get('open') == $role_id) : ?>open<? endif ?>"> <article class="indented <?= ContentBoxHelper::classes($role_id) ?> <? if (Request::get('type') === 'role' && Request::get('open') === $role_id) : ?>open<? endif ?>">
<header> <header>
<h1> <h1>
<? if (count($institute['datafields'][$role_id]) > 0): ?> <? if (isset($institute['datafields'][$role_id]) && count($institute['datafields'][$role_id]) > 0): ?>
<a href="<?= ContentBoxHelper::href($role_id) ?>" <a href="<?= ContentBoxHelper::href($role_id) ?>"
name="<?= $role_id ?>" name="<?= $role_id ?>"
class="link <?= $open === $role_id ? 'open' : 'closed' ?>"> class="link <?= Request::get('open') === $role_id ? 'open' : 'closed' ?>">
<?= htmlReady($role['name_long']) ?> <?= htmlReady($role['name_long']) ?>
</a> </a>
<? else: ?> <? else: ?>
...@@ -78,11 +78,11 @@ ...@@ -78,11 +78,11 @@
<nav> <nav>
<? if ($GLOBALS['perm']->have_studip_perm('admin', $inst_id) && !$locked) : ?> <? if ($GLOBALS['perm']->have_studip_perm('admin', $inst_id) && !$locked) : ?>
<a href="<?= $controller->url_for('settings/statusgruppen/verify/delete/' . $role_id) ?>#<?= $role_id ?>"> <a href="<?= $controller->url_for('settings/statusgruppen/verify/delete/' . $role_id) ?>#<?= $role_id ?>">
<?= Icon::create('trash', 'clickable', ['title' => _('Löschen')])->asImg() ?> <?= Icon::create('trash')->asImg(['title' => _('Löschen')]) ?>
</a> </a>
<a href="<?= URLHelper::getURL('dispatch.php/admin/statusgroups', ['cid' => $inst_id]) ?>#group-<?= $role_id ?>"> <a href="<?= URLHelper::getURL('dispatch.php/admin/statusgroups', ['cid' => $inst_id]) ?>#group-<?= $role_id ?>">
<?= Icon::create('link-intern', 'clickable', ['title' => _('Zur Funktion')])->asImg() ?> <?= Icon::create('link-intern')->asImg(['title' => _('Zur Funktion')]) ?>
</a> </a>
<? endif; ?> <? endif; ?>
</nav> </nav>
...@@ -94,8 +94,8 @@ ...@@ -94,8 +94,8 @@
'inst_id' => $inst_id, 'inst_id' => $inst_id,
'role_id' => $role_id, 'role_id' => $role_id,
'institute' => Institute::find($inst_id), 'institute' => Institute::find($inst_id),
'datafields' => $institute['datafields'][$role_id], 'datafields' => $institute['datafields'][$role_id] ?? [],
'role' => $role['role'], 'role' => $role['role'] ?? null,
]) ?> ]) ?>
</section> </section>
</article> </article>
...@@ -105,7 +105,7 @@ ...@@ -105,7 +105,7 @@
<? endforeach; ?> <? endforeach; ?>
</section> </section>
<? if ($GLOBALS['perm']->have_perm('admin') && !$locked): ?> <? if ($GLOBALS['perm']->have_perm('admin') && empty($locked)): ?>
<?= $this->render_partial('settings/statusgruppen/assign', compact('admin_insts')) ?> <?= $this->render_partial('settings/statusgruppen/assign', compact('admin_insts')) ?>
<? endif; ?> <? endif; ?>
......
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment