prevent error in strict mode and php warnings, fixes #4902

Closes #4902

Merge request studip/studip!3676

app/controllers/massmail/message.php

@@ -19,7 +19,7 @@ class Massmail_MessageController extends \AuthenticatedController
 
         $message = new \MassMail\MassMailMessage($id);
 
-        $temp_id = $id ?: uniqid(md5(time()));
+        $temp_id = $id ?: md5(uniqid(time()));
         $folder = $message->findFolder($temp_id);
 
         // SearchType needed for course selection

lib/classes/forms/Form.php

@@ -143,14 +143,14 @@ class Form extends Part
         foreach ((array) $params['types'] as $fieldname => $type) {
             $params['fields'][$fieldname]['type'] = $type;
         }
-        //respect the without param:
+        // respect the without param:
         foreach ((array) $params['without'] as $fieldname) {
             unset($params['fields'][$fieldname]);
         }
         $fields = $params['fields'];
 
-        //Now initializing the fieldset:
-        $fieldset = new Fieldset($params['legend'] ?: _("Daten"));
+        // Now initializing the fieldset:
+        $fieldset = new Fieldset($params['legend'] ?? _('Daten'));
         $fieldset->setContextObject($object)
             ->setCollapsable($params['collapsable'] ?? false)
             ->setCollapsed($params['collapsed'] ?? false);

lib/classes/forms/RadioInput.php

@@ -15,7 +15,7 @@ class RadioInput extends Input
         $template->required = $this->required;
         $template->options = $options;
         $template->attributes = arrayToHtmlAttributes($this->attributes);
-        $template->orientation = $this->attributes['orientation'];
+        $template->orientation = $this->attributes['orientation'] ?? null;
         return $template->render();
 
     }

templates/forms/radio_input.php

+<?php
+/**
+ * @var string $id
+ * @var string $name
+ * @var string $value
+ * @var string|null $orientation
+ * @var bool $required
+ * @var array $options
+ * @var string $attributes
+ */
+?>
 <div class="formpart">
-    <section <?= $this->orientation == 'horizontal' ? 'class="hgroup"' : '' ?> id="<?= htmlReady($id) ?>">
+    <section <?= $orientation == 'horizontal' ? 'class="hgroup"' : '' ?> id="<?= htmlReady($id) ?>">
     <span class="textlabel<?= $required ? ' studiprequired' : '' ?> ">
         <?= htmlReady($this->title) ?>
         <? if ($required) : ?>