fixes #4311

Closes #4311

Merge request !3115

lib/classes/helpbar/Helpbar.php

@@ -265,7 +265,7 @@ class Helpbar extends WidgetContainer
             $template = $GLOBALS['template_factory']->open('helpbar/helpbar');
             $template->widgets   = $this->widgets;
             $template->open      = $this->open;
-            $template->tour_data = $tour_data;
+            $template->tour_data = $tour_data ?? null;
             $content = $template->render();
         }
 

templates/helpbar/helpbar.php

+<?php
+/**
+ * @var bool $open
+ * @var Widget[] $widgets
+ */
+?>
 <div class="helpbar-container">
-    <?= SkipLinks::addIndex(_('Tipps & Hilfe'), 'helpbar_icon', 920) ?>
+    <? SkipLinks::addIndex(_('Tipps & Hilfe'), 'helpbar_icon', 920) ?>
     <a id="helpbar_icon" href="#" class="helpbar-toggler" data-toggles=".helpbar" role="button"
        title="<?= _('Hilfelasche anzeigen/verstecken') ?>" aria-controls="helpbar-content"
        aria-expanded="<?= $open ? 'true' : 'false' ?>">
@@ -41,7 +47,7 @@
         </ul>
     </div>
 </div>
-<? if ($tour_data['active_tour_id']) : ?>
+<? if (!empty($tour_data['active_tour_id'])) : ?>
     <script>
         STUDIP.Tour.init('<?=$tour_data['active_tour_id']?>', '<?=$tour_data['active_tour_step_nr']?>')
     </script>