Add error logging to JSONAPI of Stud.IP v5.0. (!304) · Merge requests · Stud.IP / Stud.IP · GitLab

Snippets Groups Projects

Merged Marcus Eibrink-Lunzenauer requested to merge marcus/studip:614-add-error-log-v50 into 5.0 3 years ago

1 unresolved thread

Closes #614 (closed)

Activity

Marcus Eibrink-Lunzenauer added BIEST Komponente: JSONAPI Version5.0 labels 3 years ago

added BIEST Komponente: JSONAPI Version5.0 labels
Marcus Eibrink-Lunzenauer requested review from @elmar 3 years ago

requested review from @elmar
Marcus Eibrink-Lunzenauer assigned to @marcus 3 years ago

assigned to @marcus
Elmar Ludwig @elmar started a thread on an old version of the diff 3 years ago

lib/classes/JsonApi/Errors/JsonApiExceptionHandler.php

67	67	$errors->add(new Error(null, null, $httpCode, null, $message, $details));
68	68	}
69	69
	70	if ($httpCode >= 500) {
	71	error_log((string) $exception);
Elmar Ludwig @elmar 3 years ago Owner Ich würde `$details` einfach oben immer initialisieren (nicht nur im Debug-Fall) und dann hier verwenden. Marcus Eibrink-Lunzenauer @marcus 3 years ago Author Owner Dann würden die Details auch immer (also nicht nur im Debug-Fall) in den Fehlermeldungen der JSON-API auftauchen. Das halte ich für keine gute Idee. Elmar Ludwig @elmar 3 years ago Owner Ich würde dann zumindest den Cast hier rausnehmen, der ist überflüssig und ohne ist der Code IMHO besser lesbar. Marcus Eibrink-Lunzenauer changed this line in version 2 of the diff 3 years ago changed this line in version 2 of the diff Please register or sign in to reply

Marcus Eibrink-Lunzenauer added 1 commit 3 years ago

added 1 commit

b8becbf7 - Update JsonApiExceptionHandler.php

Compare with previous version

Elmar Ludwig approved this merge request 3 years ago

approved this merge request

Marcus Eibrink-Lunzenauer added 7 commits 3 years ago

added 7 commits

b8becbf7...e8aec5a7 - 5 commits from branch studip:5.0
6d303e4e - Add error logging to v5.0 JSONAPI.
14ed81e8 - Update JsonApiExceptionHandler.php

Compare with previous version

Marcus Eibrink-Lunzenauer merged 3 years ago

merged

Elmar Ludwig mentioned in merge request !1720 (merged) 2 years ago

mentioned in merge request !1720 (merged)

Please register or sign in to reply