re #4705

lib/models/PersonalNotifications.php

@@ -94,14 +94,14 @@ class PersonalNotifications extends SimpleORMap
      * @param array|string $user_ids : array of user_ids or a single md5-user_id
      * @param string $url : URL of the point of interest of the notification
      * @param string $text : a displayed text that describes the notification
-     * @param string $html_id : id in the html-document. If user reaches
+     * @param null|string $html_id : id in the html-document. If user reaches
      *   this html-element the notification will be marked as read, so the user
-     *   does not need to handle the information twice. Optional.
-     * @param Icon|string $avatar : either an Icon or a URL of an
+     *   does not need to handle the information twice. Optional. Default: null
+     * @param null|Icon|string $avatar : either an Icon or a URL of an
      *   image for the notification. Best size: 40px x 40px
      * @return boolean : true on success
      */
-    public static function add($user_ids, $url, $text, $html_id = '', $avatar = '', $dialog = false)
+    public static function add($user_ids, $url, $text, $html_id = null, $avatar = null, $dialog = false)
     {
         if (!is_array($user_ids)) {
             $user_ids = [$user_ids];
@@ -114,10 +114,10 @@ class PersonalNotifications extends SimpleORMap
         }
 
         $notification = new self();
-        $notification['html_id'] = $html_id;
+        $notification['html_id'] = $html_id ?? '';
         $notification['url']     = $url;
         $notification['text']    = $text;
-        $notification['avatar']  = $avatar instanceof Icon ? $avatar->asImagePath(40) : $avatar;
+        $notification['avatar']  = $avatar instanceof Icon ? $avatar->asImagePath() : $avatar ?? '';
         $notification['dialog']  = $dialog ? 1 : 0;
         $notification->store();