bugfix: correctly handle empty IGNORE_SUBJECT_IDS

controllers/message.php

@@ -767,7 +767,7 @@ class MessageController extends AuthenticatedController {
                 dgettext('garuda', 'Ihre Nachricht an %u Personen wurde gespeichert.'),
                 count($this->flash['users'])));
         } else {
-            PageLayout::postSuccess(sprintf(
+            PageLayout::postError(sprintf(
                 dgettext('garuda', 'Ihre Nachricht an %u Personen konnte nicht gespeichert werden.'),
                 count($this->flash['users'])));
         }

models/GarudaModel.php

@@ -256,7 +256,7 @@ class GarudaModel {
                         JOIN `auth_user_md5` a USING (`user_id`)
                     WHERE s.`fach_id` NOT IN (:ignored)
                         AND a.`visible` != 'never'",
-                ['ignored' => Config::get()->GARUDA_IGNORE_SUBJECT_IDS]
+                ['ignored' => Config::get()->GARUDA_IGNORE_SUBJECT_IDS ?: ['']]
             );
         } else {
             $query = "SELECT DISTINCT `user_id` FROM `user_studiengang`";
@@ -273,15 +273,13 @@ class GarudaModel {
                     $parameters[] = $entry['fach_id'];
                 }
                 $where .= " AND `fach_id` NOT IN (?)";
-                $parameters[] = Config::get()->GARUDA_IGNORE_SUBJECT_IDS;
+                $parameters[] = Config::get()->GARUDA_IGNORE_SUBJECT_IDS ?: [''];
                 $query .= $where;
                 return DBManager::get()->fetchFirst($query, $parameters);
             } else {
                 return [];
             }
-            return DBManager::get()->fetchFirst($query, $parameters);
         }
-        return array();
     }
 
     public static function getAllEmployees($userId, $config)

plugin.manifest

 pluginname=Garuda
 pluginclassname=GarudaPlugin
 origin=intelec
-version=2.14
+version=2.14.1
 description=Allows mail sending to selectable target audiences.
 studipMinVersion=5.3
 studipMaxVersion=5.9.99