Skip to content
Snippets Groups Projects

Simple saml review

Merged Jan-Hendrik Willms requested to merge studip/studip:simple-saml-review into SimpleSamlPHP

I made the review in the form a merge request since the changes are somehow difficult to address via suggestions.

The main things I changed:

  • The SimpleSAMLPHP library should and must be included via composer
  • The code that actually authenticates against the saml idp was duplicated. I'm not really sure where it should better be - in the constructor or verifyUsername(). Other plugins tend to use verifyUsername().
  • The rest is basically formal stuff regarding compliance to PSR-12 or using the features PHP8 provides.

I hope, I didn't break anything. If this MR will be merged into the original TIC, I will request another review from someone else and then the auth plugin can hopefully get included in Stud.IP 6.0.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
Please register or sign in to reply
Loading