fixes #2863

Closes #2863

Merge request studip/studip!1940

app/views/course/lvgselector/index.php

 <? if (!$locked) : ?>
 <form action="<?= $controller->link_for('course/lvgselector/index/' . $course_id, $url_params ?? []) ?>"
     <?= Request::isDialog() ? 'data-dialog' : '' ?>
-          method="post">
+      method="post" class="default">
     <? endif ?>
-<h1><?= _('Lehrveranstaltungsgruppen') ?></h1>
+    <fieldset>
+        <legend><?= _('Lehrveranstaltungsgruppen') ?></legend>
         <div id="assigned" data-ajax-url="<?= $ajax_url ?>" data-forward-url="<?= $no_js_url ?>">
             <h2>
         <span class="required">
@@ -19,20 +20,16 @@
                     </ul>
                 </li>
             </ul>
-    <? if (!$locked) : ?>
-    <div data-dialog-button class="hidden-no-js">
-        <?= Studip\Button::createAccept(_('Speichern'), 'save') ?>
-    </div>
-    <? endif ?>
         </div>
         <? if (!$locked) : ?>
             <div id="lvgroup-tree-open-nodes">
                 <? foreach ($open_lvg_nodes as $opennode): ?>
                     <input type="hidden" name="open_lvg_nodes[]" value="<?= htmlReady($opennode) ?>">
-    <? endforeach; ?>
+                <? endforeach ?>
             </div>
             <div id="studyareas" data-ajax-url="<?= $ajax_url ?>"
-        data-forward-url="<?= $no_js_url ?>" data-no-search-result="<?=_('Es wurde kein Suchergebnis gefunden.') ?>">
+                 data-forward-url="<?= $no_js_url ?>"
+                 data-no-search-result="<?= _('Es wurde kein Suchergebnis gefunden.') ?>">
                 <h2><?= _('Lehrveranstaltungsgruppen Suche') ?></h2>
                 <div>
                     <input type="text" style="width: auto;" size="40" name="search" id="lvgroup-tree-search">
@@ -67,8 +64,8 @@
                                         'open_nodes' => $open_lvg_nodes ?? [],
                                         'children'   => $children,
                                     ]) ?>
-                    <? endif; ?>
-                <? endforeach; ?>
+                                <? endif ?>
+                            <? endforeach ?>
                         </ul>
                     </li>
                 </ul>
@@ -79,10 +76,10 @@
             <script>
                 //<!--
                 $(function () {
-        var element = $('#lvgroup-tree-search');
+                    let element = $('#lvgroup-tree-search');
                     element.on('keypress', function (e) {
-            if (e.keyCode == 13) {
-                if (element.val() != '') {
+                        if (e.keyCode === 13) {
+                            if (element.val() !== '') {
                                 return STUDIP.MVV.CourseWizard.searchTree();
                             } else {
                                 return STUDIP.MVV.CourseWizard.resetSearch();
@@ -93,6 +90,10 @@
                 //-->
             </script>
         <? endif ?>
+    </fieldset>
     <? if (!$locked) : ?>
+    <footer data-dialog-button class="hidden-no-js">
+        <?= Studip\Button::createAccept(_('Speichern'), 'save') ?>
+    </footer>
 </form>
 <? endif ?>

app/views/course/study_areas/show.php

 <? if (!$locked) : ?>
 <form action="<?= $controller->link_for('course/study_areas/save/' . $course->id, $url_params) ?>"
     <?= Request::isDialog() ? 'data-dialog' : '' ?>
-          method="post">
+      method="post" class="default">
     <? endif ?>
     <?= $tree ?>
-    <div style="text-align: center;">
-    <? if ($is_activated) : ?>
-        <? if ($is_required) : ?>
-            <?= _("Die Veranstaltung muss <b>mindestens einen</b> Studienbereich haben.") ?>
-        <? endif ?>
-    <? else : ?>
-        <?= _("Die Veranstaltung darf <b>keine</b> Studienbereiche haben.") ?>
-    <? endif ?>
-    </div>
     <? if (!$locked) : ?>
 </form>
 <? endif ?>

app/views/course/wizard/steps/studyareas/index.php

-<legend>
-    <?= _('Studienbereiche') ?>
-</legend>
+<? if (!$stepnumber) : ?>
+    <fieldset>
+<? endif ?>
+    <legend><?= _('Studienbereiche') ?></legend>
     <div id="assigned">
         <h2>
         <span class="required">
@@ -19,15 +20,11 @@
                 </ul>
             </li>
         </ul>
-    <? if (!$stepnumber && empty($values['locked'])) : ?>
-        <div data-dialog-button class="hidden-no-js">
-            <?= Studip\Button::createAccept(_('Speichern'), 'save') ?>
-        </div>
-    <? endif ?>
     </div>
     <? if (empty($values['locked'])) : ?>
     <div id="studyareas" data-ajax-url="<?= $ajax_url ?>"
-        data-forward-url="<?= $no_js_url ?>" data-no-search-result="<?=_('Es wurde kein Suchergebnis gefunden.') ?>">
+         data-forward-url="<?= $no_js_url ?>"
+         data-no-search-result="<?= _('Es wurde kein Suchergebnis gefunden.') ?>">
         <h2><?= _('Alle Studienbereiche') ?></h2>
         <div>
             <input style="width:auto" type="text" size="40" name="search" id="sem-tree-search">
@@ -40,7 +37,7 @@
         </div>
         <div id="sem-tree-assign-all" class="hidden-js hidden-no-js">
             <a href="" onclick="return STUDIP.CourseWizard.assignAllNodes()">
-                <?= Icon::create('arr_2left', 'sort')->asImg() ?>
+                <?= Icon::create('arr_2left', Icon::ROLE_SORT) ?>
                 <?= _('Alle Suchergebnisse zuweisen') ?>
             </a>
         </div>
@@ -67,13 +64,22 @@
     <?php if (!empty($values['open_node'])) : ?>
         <input type="hidden" name="open_node" value="<?= $values['open_node'] ?>"/>
     <?php endif ?>
+    <div class="clear"></div>
+<? if (!$stepnumber) : ?>
+    </fieldset>
+<? endif ?>
+<? if (!$stepnumber && empty($values['locked'])) : ?>
+    <footer data-dialog-button class="hidden-no-js">
+        <?= Studip\Button::createAccept(_('Speichern'), 'save') ?>
+    </footer>
+<? endif ?>
 <script>
     //<!--
     $(function () {
-        var element = $('#sem-tree-search');
+        let element = $('#sem-tree-search');
         element.on('keypress', function (e) {
-            if (e.keyCode == 13) {
-                if (element.val() != '') {
+            if (e.keyCode === 13) {
+                if (element.val() !== '') {
                     return STUDIP.CourseWizard.searchTree();
                 } else {
                     return STUDIP.CourseWizard.resetSearch();