let sidebar buttons extend from button.as-link instead of requiring the class...

let sidebar buttons extend from button.as-link instead of requiring the class set on the button, re #1474

Merge request studip/studip!2053

lib/classes/sidebar/LinkElement.php

@@ -226,7 +226,7 @@ class LinkElement extends WidgetElement implements ArrayAccess
     protected function renderButton()
     {
         return sprintf(
-            '<button formaction="%s" class="as-link" %s>%s</button>',
+            '<button formaction="%s" %s>%s</button>',
             htmlReady($this->url),
             arrayToHtmlAttributes((array) $this->attributes),
             htmlReady($this->label)

lib/classes/sidebar/OptionsWidget.php

@@ -34,7 +34,7 @@ class OptionsWidget extends ListWidget
         $toggle_url_off = isset($toggle_url_off) ? html_entity_decode($toggle_url_off) : null;
 
         $content = sprintf(
-            '<button formaction="%s" role="checkbox" aria-checked="%s" class="as-link options-checkbox options-%s" %s>%s</button>',
+            '<button formaction="%s" role="checkbox" aria-checked="%s" class="options-checkbox options-%s" %s>%s</button>',
             htmlReady($state && $toggle_url_off !== null ? $toggle_url_off : $toggle_url),
             $state ? 'true' : 'false',
             $state ? 'checked' : 'unchecked',
@@ -55,7 +55,7 @@ class OptionsWidget extends ListWidget
         $url = html_entity_decode($url);
 
         $content = sprintf(
-            '<button formaction="%s" role="radio" aria-checked="%s" class="as-link options-radio options-%s" %s>%s</button>',
+            '<button formaction="%s" role="radio" aria-checked="%s" class="options-radio options-%s" %s>%s</button>',
             htmlReady($url),
             $checked ? 'true' : 'false',
             $checked ? 'checked' : 'unchecked',

resources/assets/stylesheets/scss/sidebar.scss

@@ -125,6 +125,7 @@ ul.widget-list {
     }
 
     button {
+        @extend .as-link;
         text-align: left;
         width: 100%;
     }