prevent php8-warnings, refs #1733

Merge request !1128

app/controllers/admin/statusgroups.php

@@ -61,7 +61,7 @@ class Admin_StatusgroupsController extends AuthenticatedController
     {
         $lockrule = LockRules::getObjectRule(Context::getId());
         $this->is_locked = LockRules::Check(Context::getId(), 'groups');
-        if ($lockrule->description && $this->is_locked) {
+        if ($lockrule && $lockrule->description && $this->is_locked) {
             PageLayout::postMessage(MessageBox::info(formatLinks($lockrule->description)));
         }
         // Setup sidebar.

app/controllers/course/members.php

@@ -177,7 +177,7 @@ class Course_MembersController extends AuthenticatedController
                 PageLayout::postMessage(MessageBox::info(formatLinks($lockdata['description'])));
             }
         }
-
+        $this->to_waitlist_actions = false;
         // Check for waitlist availability (influences available actions)
         // People can be moved to waitlist if waitlist available and no automatic moving up.
         if (!$sem->admission_disable_waitlist && $sem->admission_disable_waitlist_move

app/controllers/course/messenger.php

@@ -39,7 +39,7 @@ class Course_MessengerController extends AuthenticatedController
         $this->thread->markAsRead();
 
         $this->thread_data = $this->thread->getJSONData();
-
+        $_SESSION['already_asked_for_avatar'] = false;
         if (!Avatar::getAvatar($GLOBALS['user']->id)->is_customized() && !$_SESSION['already_asked_for_avatar']) {
             $_SESSION['already_asked_for_avatar'] = true;
             PageLayout::postInfo(sprintf(_("Wollen Sie ein Avatar-Bild nutzen? %sLaden Sie jetzt ein Bild hoch%s."), '<a href="'.URLHelper::getURL("dispatch.php/avatar/update/user/".$GLOBALS['user']->id).'" data-dialog>', '</a>'));

app/controllers/course/statusgroups.php

@@ -137,13 +137,16 @@ class Course_StatusgroupsController extends AuthenticatedController
                     }
                 }
                 $groupdata['load'] = true;
+            } else {
+                $groupdata['load'] = false;
             }
 
             if (!$this->is_tutor && $g->userMayJoin($GLOBALS['user']->id)) {
-                $groupdata['joinable'] = true;
                 $joinable = true;
+            } else {
+                $joinable = false;
             }
-
+            $groupdata['joinable'] = $joinable;
             $this->groups[] = $groupdata;
         }
 
@@ -161,8 +164,8 @@ class Course_StatusgroupsController extends AuthenticatedController
                     "SELECT `statusgruppe_id` FROM `statusgruppen` WHERE `range_id` = ?",
                     [$this->course_id])
             ]);
-        $ungrouped_count = $ungrouped_count[0];
-        if ($ungrouped_count > 0) {
+        $this->ungrouped_count = $ungrouped_count[0];
+        if ($this->ungrouped_count > 0) {
             // Create dummy entry for "no group" users.
             $no_group = new StdClass();
             $no_group->id = 'nogroup';
@@ -172,7 +175,7 @@ class Course_StatusgroupsController extends AuthenticatedController
 
             $groupdata = [
                 'group' => $no_group,
-                'membercount' => $ungrouped_count,
+                'membercount' => $this->ungrouped_count,
                 'joinable' => false,
                 'invisible_users' => 0,
                 'members' => []
@@ -214,6 +217,8 @@ class Course_StatusgroupsController extends AuthenticatedController
                 }
             }
             $this->groups[] = $groupdata;
+        } else {
+            $this->nogroupmembers = [];
         }
 
         // Prepare search object for MultiPersonSearch.
@@ -300,6 +305,7 @@ class Course_StatusgroupsController extends AuthenticatedController
      */
     public function getgroup_action($group_id)
     {
+        $this->sort_by = '';
         if ($group_id != 'nogroup') {
             $this->group = Statusgruppen::find($group_id);
             $this->members = [];

app/controllers/course/wizard.php

@@ -419,9 +419,9 @@ class Course_WizardController extends AuthenticatedController
     private function getValues($classname='')
     {
         if ($classname) {
-            return $_SESSION['coursewizard'][$this->temp_id][$classname] ?: [];
+            return $_SESSION['coursewizard'][$this->temp_id][$classname] ?? [];
         } else {
-            return $_SESSION['coursewizard'][$this->temp_id] ?: [];
+            return $_SESSION['coursewizard'][$this->temp_id] ?? [];
         }
     }
 

app/controllers/jsupdater.php

@@ -125,15 +125,15 @@ class JsupdaterController extends AuthenticatedController
     private function getBlubberUpdates($pageInfo)
     {
         $data = [];
-        if (is_array($pageInfo['blubber']['threads']) && count($pageInfo['blubber']['threads'])) {
-            $blubber_data = array();
+        if (isset($pageInfo['blubber']['threads']) && is_array($pageInfo['blubber']['threads'])) {
+            $blubber_data = [];
             foreach ($pageInfo['blubber']['threads'] as $thread_id) {
                 $thread = new BlubberThread($thread_id);
                 if ($thread->isReadable()) {
-                    $comments = BlubberComment::findBySQL("thread_id = :thread_id AND chdate >= :time ORDER BY mkdate ASC", array(
-                                                              'thread_id' => $thread_id,
-                                                              'time' => UpdateInformation::getTimestamp()
-                                                          ));
+                    $comments = BlubberComment::findBySQL(
+                        "thread_id = :thread_id AND chdate >= :time ORDER BY mkdate ASC",
+                        ['thread_id' => $thread_id, 'time' => UpdateInformation::getTimestamp()]
+                    );
                     foreach ($comments as $comment) {
                         $blubber_data[$thread_id][] = $comment->getJSONdata();
                     }
@@ -161,14 +161,14 @@ class JsupdaterController extends AuthenticatedController
         if (mb_stripos(Request::get("page"), "dispatch.php/blubber") !== false) {
             //collect updated threads for the widget
             $threads = BlubberThread::findMyGlobalThreads(30, UpdateInformation::getTimestamp());
-            $thread_widget_data = array();
+            $thread_widget_data = [];
             foreach ($threads as $thread) {
-                $thread_widget_data[] = array(
+                $thread_widget_data[] = [
                     'thread_id' => $thread->getId(),
                     'avatar' => $thread->getAvatar(),
                     'name' => $thread->getName(),
                     'timestamp' => (int) $thread->getLatestActivity()
-                );
+                ];
             }
             if (count($thread_widget_data)) {
                 $data['updateThreadWidget'] = $thread_widget_data;
@@ -233,20 +233,27 @@ class JsupdaterController extends AuthenticatedController
 
     private function getQuestionnaireUpdates($pageInfo)
     {
+        if (
+            !isset($pageInfo['questionnaire']['questionnaire_ids'])
+            || !is_array($pageInfo['questionnaire']['questionnaire_ids'])
+        ) {
+            return [];
+        }
+
         $data = [];
-        if (is_array($pageInfo['questionnaire']['questionnaire_ids'])) {
-            foreach ($pageInfo['questionnaire']['questionnaire_ids'] as $questionnaireId) {
-                $questionnaire = new Questionnaire($questionnaireId);
+        Questionnaire::findEachMany(
+            function (Questionnaire $questionnaire) use ($pageInfo, &$data) {
                 if ($questionnaire->latestAnswerTimestamp() > $pageInfo['questionnaire']['last_update']) {
                     $template = $this->get_template_factory()->open("questionnaire/evaluate");
                     $template->set_layout(null);
                     $template->set_attribute("questionnaire", $questionnaire);
-                    $data[$questionnaire->getId()] = [
+                    $data[$questionnaire->id] = [
                         'html' => $template->render()
                     ];
                 }
-            }
-        }
+            },
+            $pageInfo['questionnaire']['questionnaire_ids']
+        );
 
         return $data;
     }

app/controllers/messages.php

@@ -184,6 +184,7 @@ class MessagesController extends AuthenticatedController {
         PageLayout::setTitle(_('Neue Nachricht schreiben'));
 
         $this->to = [];
+        $this->answer_to = null;
         $this->default_message = new Message();
         $this->default_attachments = [];
 

app/controllers/module/module.php

@@ -854,7 +854,7 @@ class Module_ModuleController extends MVVController
             $this->modulteil_id = $this->modulteil->getId();
             $this->search_lvgruppe($this->modulteil->getId());
             if (Request::isXhr()) {
-                $this->render_template('module/module/modulteil_lvg', null);
+                $this->render_template('module/module/modulteil_lvg');
             } else {
                 $this->modul = Modul::get($this->modulteil->modul_id);
                 $this->modul_id = $this->modul->getId();
@@ -1037,6 +1037,7 @@ class Module_ModuleController extends MVVController
 
     public function details_action($modul_id, $modulteil_id = null)
     {
+        $this->institut_id = null;
         $this->modul = Modul::get($modul_id);
         $this->modul_id = $this->modul->isNew() ? null : $this->modul->getId();
         if ($modulteil_id) {

app/controllers/oer/admin.php

@@ -93,9 +93,8 @@ class Oer_AdminController extends AuthenticatedController
     {
         $data = $host->askKnownHosts();
         $added = 0;
-        if ($data['hosts']) {
+        if (!empty($data['hosts'])) {
             foreach ($data['hosts'] as $host_data) {
-
                 $host = OERHost::findOneByUrl($host_data['url']);
                 if (!$host) {
                     $host = new OERHost();

app/controllers/profile.php

@@ -240,7 +240,7 @@ class ProfileController extends AuthenticatedController
         //The profile avatar, profile visits and profile score
         //shall be visible in the sidebar. Therefore we must construct
         //a generic WidgetElement object and its HTML in here.
-
+        $kings = [];
         if (Config::Get()->SCORE_ENABLE) {
             if ($this->current_user->user_id === $GLOBALS['user']->id || $this->current_user->score) {
                 $kings = $this->current_user->getStudipKingIcon();

app/controllers/shared/contacts.php

@@ -432,7 +432,7 @@ class Shared_ContactsController extends MVVController
     public function add_ansprechpartner_action($origin = 'index', $range_type = null, $range_id = null, $user_id = null, $category = null)
     {
         PageLayout::setTitle(_('Ansprechpartner zuordnen'));
-
+        $contact_range = null;
         $this->extcontact_search_obj = new SQLSearch("SELECT extern_contact_id, mvv_extern_contacts.name "
                 . "FROM mvv_extern_contacts "
                 . "WHERE mvv_extern_contacts.name LIKE :input "
@@ -528,6 +528,10 @@ class Shared_ContactsController extends MVVController
             $this->ansp_kat = $contact_range->category;
             $this->ansp_name = $contact_range->contact->getContactName();
         } else {
+            $this->ansp_status = '';
+            $this->ansp_altmail = '';
+            $this->ansp_typ = '';
+            $this->ansp_kat = '';
             $this->ansp_name = '';
         }
 

app/controllers/studiengaenge/shared_version.php

@@ -355,6 +355,7 @@ abstract class SharedVersionController extends MVVController
 
     public function abschnitte_action($version_id)
     {
+        $this->abschnitt_id = null;
         $this->abschnitte($version_id);
         if (Request::isXhr()) {
             $this->render_template('studiengaenge/versionen/abschnitte');
@@ -673,6 +674,7 @@ abstract class SharedVersionController extends MVVController
 
     public function details_abschnitt_action($abschnitt_id, $modul_id = null)
     {
+        $this->modul_id = $modul_id;
         $this->abschnitt = StgteilAbschnitt::find($abschnitt_id);
         if (!$this->abschnitt) {
             PageLayout::postError(_('Unbekannter Abschnitt'));

app/controllers/studiengaenge/studiengangteile.php

@@ -35,10 +35,11 @@ class Studiengaenge_StudiengangteileController extends SharedVersionController
         $search_result = $this->getSearchResult('StudiengangTeil');
         $this->sortby = $this->sortby ?: 'fach_name,zusatz,kp';
         $this->order = $this->order ?: 'ASC';
-
+        $this->stgteil_id = null;
         //get data
         if (count($search_result)) {
             $filter['stgteil_id'] = $search_result;
+            $this->stgteil_id = $search_result;
             $this->stgteile = StudiengangTeil::getAllEnriched(
                 $this->sortby, $this->order,
                 $filter, self::$items_per_page,
@@ -176,7 +177,7 @@ class Studiengaenge_StudiengangteileController extends SharedVersionController
     {
         $this->stgteil = StudiengangTeil::find($stgteil_id);
         $this->versionen = StgteilVersion::findByStgteil($stgteil_id);
-
+        $this->version_id = null;
         if (count($this->versionen)) {
             $this->stgteil_id = $stgteil_id;
             if (!Request::isXhr()) {

app/views/admin/plugin/search.php

@@ -32,7 +32,7 @@
                 <td class="plugin_image">
                 <? if ($plugin['image']): ?>
                     <a href="<?= htmlReady($plugin['image']) ?>"
-                       data-lightbox="<?= htmlReady($plugin['displayname']) ?>"
+                       data-lightbox="<?= htmlReady($plugin['displayname']?? '') ?>"
                        data-title="<?= htmlReady($name) ?>">
                         <img src="<?= htmlReady($plugin['image']) ?>" class="plugin_preview">
                     </a>

app/views/course/dates/index.php

@@ -48,6 +48,7 @@
     <tbody>
     <?php
         // print dates
+        $is_next_date = null;
         foreach ($dates as $key => $date) {
             $dateSemester = Semester::findByTimestamp($date['date']);
             if ($dateSemester && $semester->getId() === $dateSemester->getId()) {

app/views/course/forum/index/_threads.php

@@ -98,8 +98,9 @@
 
                     <td class="actions">
                         <?= ActionMenu::get()
+                            ->condition(isset($entry['last_posting']))
                             ->addLink(
-                                $controller->url_for("course/forum/index/index/{$entry['last_posting']['topic_id']}#{$entry['last_posting']['topic_id']}"),
+                                isset($entry['last_posting']) ? $controller->url_for("course/forum/index/index/{$entry['last_posting']['topic_id']}#{$entry['last_posting']['topic_id']}") : '#no_posting',
                                 _('Zur letzten Antwort'),
                                 Icon::create('forum'),
                                 ['class' => 'hidden-small-up']

app/views/course/forum/index/index.php

@@ -138,7 +138,7 @@ $pagechooser = null;
         'num_postings' => $number_of_entries,
         'perPage'      => ForumEntry::POSTINGS_PER_PAGE,
         'pagelink'     => str_replace('%%s', '%s', str_replace('%', '%%', $controller->url_for('course/forum/index/goto_page/'. $topic_id .'/'. $section
-            .'/%s/?searchfor=' . $searchfor . (!empty($options) ? '&'. http_build_query($options) : '' ))))
+            .'/%s/?searchfor=' . ($searchfor ?? '') . (!empty($options) ? '&'. http_build_query($options) : '' ))))
     ]); ?>
     <? endif ?>
     <?= $link ?? ''  ?>

app/views/course/plus/index.php

@@ -13,7 +13,7 @@ use Studip\Button;
 
 ?>
 
-<form action="<?= URLHelper::getLink($save_url) ?>" method="post" class="default">
+<form action="<?= URLHelper::getLink() ?>" method="post" class="default">
     <?= CSRFProtection::tokenTag() ?>
     <input name="uebernehmen" value="1" type="hidden">
     <table class="default nohover plus">
@@ -53,7 +53,7 @@ use Studip\Button;
                     ?>
 
                     <tr id="<?= htmlReady($anchor); ?>"
-                        class="<?= $visibility; ?> <?= $pre_check != null ? ' quiet' : '' ?>">
+                        class="<?= $visibility; ?>">
                         <td class="element" colspan=3>
 
                             <div class="plus_basic">
@@ -137,7 +137,7 @@ use Studip\Button;
                                     <div class="screenshot_holder">
                                         <? if (isset($info['screenshot']) || isset($info['screenshots'])) :
                                             if (isset($info['screenshots'])) {
-                                                $title  = $info['screenshots']['pictures'][0]['title'];
+                                                $title  = $info['screenshots']['pictures'][0]['title']??'';
                                                 $source = $info['screenshots']['path'] . '/' . $info['screenshots']['pictures'][0]['source'];
                                             } else {
                                                 $fileext = pathinfo($info['screenshot'], PATHINFO_EXTENSION);
@@ -169,7 +169,7 @@ use Studip\Button;
                                                     <? for ($i = $cstart; $i < $counter; $i++) :?>
                                                         <?
                                                             if (isset($info['screenshots'])) {
-                                                                $title  = $info['screenshots']['pictures'][$i]['title'];
+                                                                $title  = $info['screenshots']['pictures'][$i]['title']?? '';
                                                                 $source = $info['screenshots']['path'] . '/' . $info['screenshots']['pictures'][$i]['source'];
                                                             } else {
                                                                 $fileext = pathinfo($info['additionalscreenshots'][$i], PATHINFO_EXTENSION);

app/views/course/statusgroups/_member.php

@@ -17,7 +17,7 @@
                 'title' => $user_fullname,
             ]) ?>
             <?= htmlReady($user_fullname) ?>
-            <?php if ($user_id == $m->user_id && $m->visible == 'no') : ?>
+            <?php if ($GLOBALS['user']->id !== $m->user_id && $m->visible == 'no') : ?>
                 (<?= _('unsichtbar') ?>)
             <?php endif ?>
         </a>