fix creation and deletion of consultation events, fixes #982

Closes #982

Merge request studip/studip!971

lib/models/ConsultationBlock.php

@@ -24,7 +24,7 @@
  * @property bool has_bookings computed column
  * @property Range range computed column
  * @property SimpleORMapCollection slots has_many ConsultationSlot
- * @property ConsultationResponsibility[] responsibilities has_many ConsultationResponsibility
+ * @property ConsultationResponsibility[]|SimpleCollection responsibilities has_many ConsultationResponsibility
  * @property User[] responsible_persons
  */
 class ConsultationBlock extends SimpleORMap implements PrivacyObject

lib/models/ConsultationEvent.php

@@ -22,7 +22,7 @@ class ConsultationEvent extends SimpleORMap
             'class_name'  => ConsultationSlot::class,
             'foreign_key' => 'slot_id',
         ];
-        $config['belongs_to']['event'] = [
+        $config['has_one']['event'] = [
             'class_name'        => EventData::class,
             'foreign_key'       => 'event_id',
             'assoc_foreign_key' => 'event_id',

lib/models/ConsultationSlot.php

@@ -193,6 +193,10 @@ class ConsultationSlot extends SimpleORMap
      */
     public function updateEvents()
     {
+        if ($this->isNew()) {
+            return;
+        }
+
         // If no range is associated, remove the event
         if (!$this->block->range) {
             $this->events->delete();