From cef096b346806dd80863ac64e7b62ccedb3e261b Mon Sep 17 00:00:00 2001
From: Jan-Hendrik Willms <tleilax+studip@gmail.com>
Date: Mon, 19 May 2025 13:55:03 +0200
Subject: [PATCH] prevent ph8 warnings, fixes #12
---
lib/ExcalidrawBlock.php | 7 ++++---
views/excalidraw/excalidraw_app.php | 2 +-
2 files changed, 5 insertions(+), 4 deletions(-)
diff --git a/lib/ExcalidrawBlock.php b/lib/ExcalidrawBlock.php
index 38631b3..5ab6188 100644
--- a/lib/ExcalidrawBlock.php
+++ b/lib/ExcalidrawBlock.php
@@ -91,14 +91,15 @@ class ExcalidrawBlock extends BlockType
public function getFiles(): array
{
$payload = $this->getPayload();
- if (!$payload['file_id'] && !$payload['folder_id']) {
+ if (empty($payload['file_id']) && empty($payload['folder_id'])) {
return [];
}
- if ($payload['file_id']) {
+ if (!empty($payload['file_id'])) {
$files = [];
- if ($fileRef = \FileRef::find($payload['file_id'])) {
+ $fileRef = \FileRef::find($payload['file_id']);
+ if ($fileRef) {
$files[] = $fileRef;
}
diff --git a/views/excalidraw/excalidraw_app.php b/views/excalidraw/excalidraw_app.php
index 3ad3570..e6d324c 100644
--- a/views/excalidraw/excalidraw_app.php
+++ b/views/excalidraw/excalidraw_app.php
@@ -22,7 +22,7 @@
<? endif ?>
<div class="excalidraw-content">
- <? if ($content_bar_text) : ?>
+ <? if (!empty($content_bar_text)) : ?>
<?= ContentBar::get()
->setTOC(new TOCItem($content_bar_text))
->setIcon(Icon::create('content'));
--
GitLab