From a5c197334f96033b6bb54aeb0f755f9acdf6198c Mon Sep 17 00:00:00 2001
From: Elmar Ludwig <elmar.ludwig@uni-osnabrueck.de>
Date: Wed, 12 May 2021 15:55:16 +0200
Subject: [PATCH] always display date of submission, fixes #62
---
controllers/solutions.php | 26 ++++++++++++++------------
1 file changed, 14 insertions(+), 12 deletions(-)
diff --git a/controllers/solutions.php b/controllers/solutions.php
index 5c56153..c19d4e2 100644
--- a/controllers/solutions.php
+++ b/controllers/solutions.php
@@ -904,20 +904,22 @@ class SolutionsController extends StudipController
}
Sidebar::get()->addWidget($widget);
- if (count($solution_archive)) {
- $widget = new SelectWidget(_vips('Versionen'), $this->url_for('solutions/edit_solution', compact('assignment_id', 'exercise_id', 'solver_id', 'view')), 'solution_id');
- $version = $solution->id ? date('d.m.Y, H:i', strtotime($solution->time)) : _vips('nicht abgegeben');
- $element = new SelectElement(0, sprintf(_vips('Aktuelle Version: %s'), $version), !$archived_id);
- $widget->addElement($element);
+ $widget = new SelectWidget(_vips('Versionen'), $this->url_for('solutions/edit_solution', compact('assignment_id', 'exercise_id', 'solver_id', 'view')), 'solution_id');
+ $version = $solution->id ? date('d.m.Y, H:i', strtotime($solution->time)) : _vips('nicht abgegeben');
+ $element = new SelectElement(0, sprintf(_vips('Aktuelle Version: %s'), $version), !$archived_id);
+ $widget->addElement($element);
- foreach ($solution_archive as $i => $old_solution) {
- $element = new SelectElement($old_solution->id,
- sprintf(_vips('Version %s vom %s'), count($solution_archive) - $i, date('d.m.Y, H:i', strtotime($old_solution->time))),
- $old_solution->id == $archived_id);
- $widget->addElement($element);
- }
- Sidebar::get()->addWidget($widget);
+ if (count($solution_archive) === 0) {
+ $widget->attributes = ['disabled' => 'disabled'];
}
+
+ foreach ($solution_archive as $i => $old_solution) {
+ $element = new SelectElement($old_solution->id,
+ sprintf(_vips('Version %s vom %s'), count($solution_archive) - $i, date('d.m.Y, H:i', strtotime($old_solution->time))),
+ $old_solution->id == $archived_id);
+ $widget->addElement($element);
+ }
+ Sidebar::get()->addWidget($widget);
}
/**
--
GitLab