diff --git a/app/controllers/course/room_requests.php b/app/controllers/course/room_requests.php index f75182c6478255698ff6e8ae02aca04ffe7c9dbe..84d0a551c12267c1812f22e67084668eb7757466 100644 --- a/app/controllers/course/room_requests.php +++ b/app/controllers/course/room_requests.php @@ -254,7 +254,7 @@ class Course_RoomRequestsController extends AuthenticatedController $this->selected_room = Resource::find($_SESSION[$request_id]['room_id'] ?: $this->request->resource_id); $this->selected_room_category_id = $this->selected_room->category_id ?? $_SESSION[$request_id]['room_category_id'] ?? null; - $this->category = ResourceCategory::find($this->selected_room_category_id); + $this->category = $this->selected_room_category_id ? ResourceCategory::find($this->selected_room_category_id) : null; $_SESSION[$request_id]['room_category_id'] = $_SESSION[$request_id]['room_category_id'] ?? $this->selected_room->category_id ?? null; @@ -546,7 +546,7 @@ class Course_RoomRequestsController extends AuthenticatedController $_SESSION[$request_id]['search_by'] = $this->selected_room ? 'roomname' : 'category'; $_SESSION[$request_id]['room_category_id'] = $this->selected_room_category->id; - $_SESSION[$request_id]['room_id'] = $this->selected_room->id; + $_SESSION[$request_id]['room_id'] = $this->selected_room ? $this->selected_room->id : ''; } public function store_request_action($request_id) diff --git a/app/views/course/room_requests/_new_request_form_footer.php b/app/views/course/room_requests/_new_request_form_footer.php index 0bad0763b6304acdefe0600801392137368ef250..0d5046747bc12ed3379066aca7eb55bddc48a67d 100644 --- a/app/views/course/room_requests/_new_request_form_footer.php +++ b/app/views/course/room_requests/_new_request_form_footer.php @@ -27,10 +27,7 @@ <? if ( ( $step === 1 - && ( - !isset($_SESSION[$request_id]['room_category_id']) - || $_SESSION[$request_id]['room_category_id'] !== '0' - ) + && !empty($_SESSION[$request_id]['room_category_id']) ) || $step === 2 ) : ?> diff --git a/lib/models/resources/ResourceCategory.class.php b/lib/models/resources/ResourceCategory.class.php index 9738cbcef7568eff4e4c68c7b35f6589a212f903..a95bcda0821e44fdca5d118dbf7dd593eeb07493 100644 --- a/lib/models/resources/ResourceCategory.class.php +++ b/lib/models/resources/ResourceCategory.class.php @@ -87,7 +87,7 @@ class ResourceCategory extends SimpleORMap public static function find($id) { $all = self::findAll(); - return $all[$id] ?: null; + return $all[$id] ?? null; } /**