From f6d9bff9532ef07b889a7750ac4bce16bb9bda74 Mon Sep 17 00:00:00 2001
From: Jan-Hendrik Willms <tleilax+studip@gmail.com>
Date: Mon, 27 Mar 2023 07:33:43 +0000
Subject: [PATCH] prevent php8 warnings, fixes #2447

Closes #2447

Merge request studip/studip!1644
---
 app/views/settings/calendar.php | 64 +++++++++++++++++----------------
 1 file changed, 34 insertions(+), 30 deletions(-)

diff --git a/app/views/settings/calendar.php b/app/views/settings/calendar.php
index e218601d717..6833a0a0f7c 100644
--- a/app/views/settings/calendar.php
+++ b/app/views/settings/calendar.php
@@ -118,36 +118,40 @@ $cal_step_weeks = [
 
     </fieldset>
 
-    <? if (Config::get()->CALENDAR_GROUP_ENABLE): ?>
-        <fieldset>
-            <legend>
-                <?= _('Gruppenterminkalender') ?>
-            </legend>
-
-            <label>
-                <?= _("Zeitintervall der Tagesansicht") ?>
-                <select name="cal_step_day_group" id="cal_step_day_group">
-                    <? foreach ($cal_step_days as $index => $label): ?>
-                        <option value="<?= $index ?>" <? if ($step_day_group == $index) echo 'selected'; ?>>
-                            <?= $label ?>
-                        </option>
-                    <? endforeach; ?>
-                </select>
-            </label>
-
-            <label>
-                <?= _('Zeitintervall der Wochenansicht') ?>
-                <select name="cal_step_week_group" id="cal_step_week_group">
-                    <? foreach ($cal_step_weeks as $index => $label): ?>
-                        <option value="<?= $index ?>" <? if ($step_week_group == $index) echo 'selected'; ?>>
-                            <?= $label ?>
-                        </option>
-                    <? endforeach; ?>
-                </select>
-            </label>
-
-        </fieldset>
-    <? endif ?>
+<? if (Config::get()->CALENDAR_GROUP_ENABLE): ?>
+    <fieldset>
+        <legend>
+            <?= _('Gruppenterminkalender') ?>
+        </legend>
+
+        <label>
+            <?= _("Zeitintervall der Tagesansicht") ?>
+            <select name="cal_step_day_group" id="cal_step_day_group">
+            <? foreach ($cal_step_days as $index => $label): ?>
+                <option value="<?= $index ?>"
+                         <? if (isset($step_day_group) && $step_day_group == $index) echo 'selected'; ?>
+                >
+                    <?= $label ?>
+                </option>
+            <? endforeach; ?>
+            </select>
+        </label>
+
+        <label>
+            <?= _('Zeitintervall der Wochenansicht') ?>
+            <select name="cal_step_week_group" id="cal_step_week_group">
+            <? foreach ($cal_step_weeks as $index => $label): ?>
+                <option value="<?= $index ?>"
+                        <? if (isset($step_week_group) && $step_week_group == $index) echo 'selected'; ?>
+                >
+                    <?= $label ?>
+                </option>
+            <? endforeach; ?>
+            </select>
+        </label>
+
+    </fieldset>
+<? endif ?>
 
     <footer>
         <? if (Request::option('atime')): ?>
-- 
GitLab