From f3fe3fb33ab720b76f727d38a5366b86ffe5ad8e Mon Sep 17 00:00:00 2001
From: Jan-Hendrik Willms <tleilax+studip@gmail.com>
Date: Tue, 28 Feb 2023 09:54:40 +0000
Subject: [PATCH] hidden info shall not be part of the link, fixes #2224
Closes #2224
Merge request studip/studip!1457
---
resources/vue/components/MyCourses.vue | 11 +++++++++++
resources/vue/components/MyCoursesTables.vue | 9 ++++-----
resources/vue/components/MyCoursesTiles.vue | 15 ++++++++-------
3 files changed, 23 insertions(+), 12 deletions(-)
diff --git a/resources/vue/components/MyCourses.vue b/resources/vue/components/MyCourses.vue
index 3e99ad79f79..769d3152a4e 100644
--- a/resources/vue/components/MyCourses.vue
+++ b/resources/vue/components/MyCourses.vue
@@ -72,3 +72,14 @@ export default {
}
}
</script>
+
+<style lang="scss">
+.course-hidden-info {
+ white-space: nowrap;
+
+ img,
+ svg {
+ vertical-align: text-bottom;
+ }
+}
+</style>
diff --git a/resources/vue/components/MyCoursesTables.vue b/resources/vue/components/MyCoursesTables.vue
index 0a5abad846c..00b24459c31 100644
--- a/resources/vue/components/MyCoursesTables.vue
+++ b/resources/vue/components/MyCoursesTables.vue
@@ -48,12 +48,11 @@
<a :href="urlFor('seminar_main.php', {auswahl: course.id})">
{{ getCourseName(course, getConfig('sem_number') && responsiveDisplay) }}
<span v-if="course.is_deputy">{{ $gettext('[Vertretung]') }}</span>
-
- <span v-if="course.is_hidden">
- {{ $gettext('[versteckt]') }}
- <studip-tooltip-icon :text="getHiddenTooltip(course)"></studip-tooltip-icon>
- </span>
</a>
+ <span v-if="course.is_hidden" class="course-hidden-info">
+ {{ $gettext('[versteckt]') }}
+ <studip-tooltip-icon :text="getHiddenTooltip(course)"></studip-tooltip-icon>
+ </span>
<div v-if="responsiveDisplay" class="mycourse_elements">
<div class="special_nav">
<studip-action-menu :items="getActionMenuForCourse(course)"
diff --git a/resources/vue/components/MyCoursesTiles.vue b/resources/vue/components/MyCoursesTiles.vue
index 71c5b645384..236ba6899dc 100644
--- a/resources/vue/components/MyCoursesTiles.vue
+++ b/resources/vue/components/MyCoursesTiles.vue
@@ -30,12 +30,13 @@
{{ getCourseName(course, getConfig('sem_number')) }}
<span v-if="course.is_deputy">{{ $gettext('[Vertretung]') }}</span>
- <span v-if="course.is_hidden">
- {{ $gettext('[versteckt]') }}
- <studip-tooltip-icon :text="getHiddenTooltip(course)"></studip-tooltip-icon>
- </span>
</span>
</a>
+
+ <span v-if="course.is_hidden" class="course-hidden-info">
+ {{ $gettext('[versteckt]') }}
+ <studip-tooltip-icon :text="getHiddenTooltip(course)"></studip-tooltip-icon>
+ </span>
</header>
<footer class="tiles-grid-element-footer">
<my-courses-navigation :navigation="getNavigationForCourse(course)" :icon-size="iconSize"></my-courses-navigation>
@@ -188,9 +189,6 @@ $tile-padding: 10px;
.tiles-grid-element-header {
flex: 0 $header-size;
- }
-
- .tiled-grid-element-header-title {
display: -webkit-box;
-webkit-line-clamp: 3;
-webkit-box-orient: vertical;
@@ -198,6 +196,9 @@ $tile-padding: 10px;
overflow: hidden;
}
+ //.tiled-grid-element-header-title {
+ //}
+
.tiles-grid-element-header-image {
float: left;
display: block;
--
GitLab