diff --git a/app/controllers/search/module.php b/app/controllers/search/module.php index 38106ea7d924a9e6dd6414eeaa7aa0aacd753735..e772d1efe118cb1e202feb90b3867a046833783e 100644 --- a/app/controllers/search/module.php +++ b/app/controllers/search/module.php @@ -112,8 +112,13 @@ class Search_ModuleController extends MVVController $modul = Modul::find($mod_id); $start_sem = Semester::find($modul->start); $end_sem = Semester::find($modul->end); - if ($start_sem->beginn > $this->selected_semester->beginn - || ($this->selected_semester->ende > $end_sem->ende && $end_sem != null)) { + if ( + $start_sem->beginn > $this->selected_semester->beginn + || ( + isset($end_sem) + && $this->selected_semester->ende > $end_sem->ende + ) + ) { unset($this->search_result['Modul'][$i]); } } diff --git a/app/views/search/module/_modul.php b/app/views/search/module/_modul.php index 53c05d873106851cdc8d7ab84c24ff8694266ba7..2fdd755de1e85e39552d8ce3ee0862fa03edabe1 100644 --- a/app/views/search/module/_modul.php +++ b/app/views/search/module/_modul.php @@ -1,4 +1,12 @@ -<tbody class="<?= $modul_id == $modul->id ? 'not-collapsed' : 'collapsed' ?>"> +<?php +/** + * @var string|null $modul_id + * @var Modul $modul + * @var Semester $selected_semester + * @var Search_ModuleController $controller + */ +?> +<tbody class="<?= (isset($modul_id) && $modul_id == $modul->id) ? 'not-collapsed' : 'collapsed' ?>"> <tr class="table-header header-row" id="modul_<?= htmlReady($modul->id) ?>"> <td style="vertical-align: middle; text-align: center;"> <a data-dialog="size=auto" title="<?= htmlReady($modul->getDisplayName()) . ' (' . _('Vollständige Modulbeschreibung') . ')' ?>" href="<?= $controller->link_for('shared/modul/description/' . $modul->id) ?>"> @@ -25,7 +33,7 @@ <? endif; ?> </td> </tr> -<? if ($details_id == $modul->id): ?> +<? if (isset($details_id) && $details_id == $modul->id): ?> <?= $this->render_partial('search/module/details') ?> <? endif; ?> </tbody> diff --git a/lib/classes/I18NStringDatafield.php b/lib/classes/I18NStringDatafield.php index 26e51a81ec3fae9a544f8388071faa60096af02a..5eee65d4d2aac4a5c38ad750ee3216caacb180dd 100644 --- a/lib/classes/I18NStringDatafield.php +++ b/lib/classes/I18NStringDatafield.php @@ -91,7 +91,7 @@ class I18NStringDatafield extends I18NString "`datafield_id` = ? AND `range_id` = ? AND `sec_range_id` = ? AND `lang` = ''", $object_id ); - $base = $df->content; + $base = $df->content ?? ''; } $table = null; $field = null; diff --git a/lib/models/Modul.php b/lib/models/Modul.php index 2d8757c42626e08bd0024bfbaa7901a7e9b25ca7..1d0ca3353d44e2048dcfb08e354a4d6daab24df0 100644 --- a/lib/models/Modul.php +++ b/lib/models/Modul.php @@ -1034,7 +1034,7 @@ class Modul extends ModuleManagementModelTreeItem foreach ($this->modulteile as $modulteil) { $mt_courses = $modulteil->getAssignedCoursesBySemester($semester_id, $only_visible); foreach ($mt_courses as $course) { - $courses[$course->id] = $course; + $courses[$course['seminar_id']] = $course; } } return $courses; diff --git a/lib/models/Modulteil.php b/lib/models/Modulteil.php index 427610b43c5004c2737dc48253585b9328fbe58d..089246bf48767ddb5563de0601c0d1e00f9df5cc 100644 --- a/lib/models/Modulteil.php +++ b/lib/models/Modulteil.php @@ -394,7 +394,7 @@ class Modulteil extends ModuleManagementModelTreeItem foreach ($this->lvgruppen as $lvgruppe) { $lvg_courses = $lvgruppe->getAssignedCoursesBySemester($semester_id, $only_visible); foreach ($lvg_courses as $course) { - $courses[$course->id] = $course; + $courses[$course['seminar_id']] = $course; } } return $courses;