From bbd06b0c4506231eab1d8a089ca6d27de0dc8461 Mon Sep 17 00:00:00 2001
From: Jan-Hendrik Willms <tleilax+studip@gmail.com>
Date: Fri, 26 Jan 2024 08:33:30 +0000
Subject: [PATCH] fixes #3674
Closes #3674
Merge request studip/studip!2547
---
lib/classes/TreeAbstract.class.php | 2 +-
templates/dates/seminar_html.php | 2 +-
templates/dates/seminar_html_location.php | 4 ++--
3 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/lib/classes/TreeAbstract.class.php b/lib/classes/TreeAbstract.class.php
index 69fedce91cb..ccdb6e11760 100644
--- a/lib/classes/TreeAbstract.class.php
+++ b/lib/classes/TreeAbstract.class.php
@@ -358,7 +358,7 @@ class TreeAbstract {
*/
public function getParents($item_id)
{
- if (!$this->tree_data[$item_id]) {
+ if (empty($this->tree_data[$item_id])) {
return [];
}
diff --git a/templates/dates/seminar_html.php b/templates/dates/seminar_html.php
index b91079a7b18..47aa0aa01c4 100644
--- a/templates/dates/seminar_html.php
+++ b/templates/dates/seminar_html.php
@@ -1,6 +1,6 @@
<?php
if (!$dates['regular']['turnus_data'] && empty($dates['irregular'])) {
- if ($dates['ort'] && $show_room) {
+ if ($dates['ort'] && !empty($show_room)) {
echo htmlReady($dates['ort']);
} else {
echo _('Die Zeiten der Veranstaltung stehen nicht fest.');
diff --git a/templates/dates/seminar_html_location.php b/templates/dates/seminar_html_location.php
index faf208a13cb..72a5fc33ba1 100644
--- a/templates/dates/seminar_html_location.php
+++ b/templates/dates/seminar_html_location.php
@@ -80,7 +80,7 @@ endforeach;
<? if (count($output) === 0) : ?>
- <?= htmlReady($ort) ?: _('Keine Raumangabe') ?>
+ <?= empty($ort) ? _('Keine Raumangabe') : htmlReady($ort) ?>
<? else: ?>
<dl>
<? foreach ($output as $room_html => $dates) : ?>
@@ -91,5 +91,5 @@ endforeach;
</dd>
<? endforeach ?>
<? endforeach ?>
- </table>
+ </dl>
<? endif ?>
--
GitLab