diff --git a/lib/cronjobs/garbage_collector.class.php b/lib/cronjobs/garbage_collector.class.php index 1d060068705455cba864fe1f2e5301a84cac1000..c56865d7c4b7fa38cd068b9de467b5a2efb86924 100644 --- a/lib/cronjobs/garbage_collector.class.php +++ b/lib/cronjobs/garbage_collector.class.php @@ -157,6 +157,13 @@ class GarbageCollectorJob extends CronJob $statement->execute(); } + // Remove outdated entries from forum_visits + $query = "DELETE FROM `forum_visits` + WHERE GREATEST(`visitdate`, `last_visitdate`) < UNIX_TIMESTAMP() - :threshold"; + DBManager::get()->execute($query, [ + ':threshold' => ForumVisit::LAST_VISIT_MAX, + ]); + // clean db cache $cache = new StudipDbCache(); $cache->purge(); diff --git a/lib/models/Course.class.php b/lib/models/Course.class.php index c449922b65e9e0e6a95f3bb6abf38b3da341276c..ab582196a4d32faeeb36475b57f5bf83d5a22247 100644 --- a/lib/models/Course.class.php +++ b/lib/models/Course.class.php @@ -278,6 +278,10 @@ class Course extends SimpleORMap implements Range, PrivacyObject, StudipItem, Fe "UPDATE `seminare` SET `parent_course` = NULL WHERE `parent_course` = :course", ['course' => $course->id] ); + DBManager::get()->execute( + "DELETE FROM `forum_visits` WHERE `seminar_id` = ?", + [$course->id] + ); }; parent::configure($config); diff --git a/lib/models/User.class.php b/lib/models/User.class.php index bb23ca36df21f7ce510e2132343f90fb77563d1e..627673d65b6d41c70773808e6251dabf0e19dfc4 100644 --- a/lib/models/User.class.php +++ b/lib/models/User.class.php @@ -211,6 +211,7 @@ class User extends AuthUserMd5 implements Range, PrivacyObject }; $config['registered_callbacks']['after_delete'][] = 'cbRemoveFeedback'; + $config['registered_callbacks']['after_delete'][] = 'cbRemoveForumVisits'; $config['registered_callbacks']['before_store'][] = 'cbClearCaches'; $config['registered_callbacks']['before_store'][] = 'cbStudipLog'; @@ -1490,6 +1491,17 @@ class User extends AuthUserMd5 implements Range, PrivacyObject FeedbackEntry::deleteBySQL('user_id = ?', [$this->id]); } + /** + * This callback is called after deleting a User. + * It removes forum visit entries that are associated with the User. + */ + public function cbRemoveForumVisits() + { + $query = "DELETE FROM `forum_visits` + WHERE `user_id` = ?"; + DBManager::get()->execute($query, [$this->id]); + } + public function cbClearCaches() { if ($this->isFieldDirty('perms')) {