From a57302ac5113dab2796de66b4f4198f5fe6cac1b Mon Sep 17 00:00:00 2001
From: David Siegfried <david.siegfried@uni-vechta.de>
Date: Fri, 25 Oct 2024 12:27:27 +0000
Subject: [PATCH] prevent php-warnings in adminssion, fixes #4767
Closes #4767
Merge request studip/studip!3553
---
app/controllers/course/admission.php | 2 ++
app/views/course/admission/_change_admission.php | 15 ++++++++++++---
2 files changed, 14 insertions(+), 3 deletions(-)
diff --git a/app/controllers/course/admission.php b/app/controllers/course/admission.php
index a2b7df4e689..94f8415e7c2 100644
--- a/app/controllers/course/admission.php
+++ b/app/controllers/course/admission.php
@@ -317,6 +317,7 @@ class Course_AdmissionController extends AuthenticatedController
} else {
$this->request = $request;
$this->button_yes = 'change_admission_turnout_yes';
+ $this->button_no = 'change_admission_turnout_no';
PageLayout::postInfo($question);
$this->render_template('course/admission/_change_admission.php');
}
@@ -405,6 +406,7 @@ class Course_AdmissionController extends AuthenticatedController
} else {
$this->request = ['change_course_set_unassign' => 1];
$this->button_yes = 'change_course_set_unassign_yes';
+ $this->button_no = 'change_course_set_unassign_no';
PageLayout::postInfo($question);
$this->render_template('course/admission/_change_admission.php');
}
diff --git a/app/views/course/admission/_change_admission.php b/app/views/course/admission/_change_admission.php
index ca26341cced..772954b57c9 100644
--- a/app/views/course/admission/_change_admission.php
+++ b/app/views/course/admission/_change_admission.php
@@ -1,3 +1,12 @@
+<?php
+/**
+ * @var Course_AdmissionController $controller
+ * @var array $request
+ * @var string $button_yes
+ * @var string $button_no
+ */
+?>
+
<? foreach(PageLayout::getMessages() as $pm) : ?>
<?= $pm ?>
<? endforeach; ?>
@@ -7,7 +16,7 @@
<?= addHiddenFields($k, $v) ?>
<? endforeach ?>
<footer data-dialog-button>
- <?= Studip\Button::create(_("Ja"), $button_yes, ['data-dialog' => ''])?>
- <?= Studip\Button::create(_("Nein"), $button_no, ['data-dialog' => ''])?>
+ <?= Studip\Button::create(_('Ja'), $button_yes, ['data-dialog' => ''])?>
+ <?= Studip\Button::create(_('Nein'), $button_no, ['data-dialog' => ''])?>
</footer>
-</form>
\ No newline at end of file
+</form>
--
GitLab