diff --git a/app/controllers/course/room_requests.php b/app/controllers/course/room_requests.php index 926e000a441161df5644ef8cf98a472082426ec6..b0910473038d404fa7ad2f0ad1c57b7d5c55ed5d 100644 --- a/app/controllers/course/room_requests.php +++ b/app/controllers/course/room_requests.php @@ -583,9 +583,11 @@ class Course_RoomRequestsController extends AuthenticatedController $this->request->store(); //Store the properties: - foreach ($_SESSION[$request_id]['selected_properties'] as $name => $state) { - if (!empty($state)) { - $this->request->setProperty($name, $state); + if (isset($_SESSION[$request_id]['selected_properties'])) { + foreach ($_SESSION[$request_id]['selected_properties'] as $name => $state) { + if (!empty($state)) { + $this->request->setProperty($name, $state); + } } } diff --git a/app/views/materialien/files/add_dokument.php b/app/views/materialien/files/add_dokument.php index a940e95a24cedb319ebf68b556947666652d151e..db6c7c6f4a0d2a40185c0d05be820e3cbfc39726 100644 --- a/app/views/materialien/files/add_dokument.php +++ b/app/views/materialien/files/add_dokument.php @@ -1,21 +1,21 @@ -<form class="default" action="<?= $controller->action_link('add_dokument', $origin, $range_type, $range_id, $mvvfile_id) ?>" method="post" data-dialog="size=auto"> - <input type="hidden" name="mvvfile_id" id="mvvfile_id" value="<?= htmlReady($mvvfile_id) ?>"> - <input type="hidden" name="range_id" id="range_id" value="<?= htmlReady($range_id) ?>"> - <input type="hidden" name="range_type" id="range_type" value="<?= htmlReady($range_type) ?>"> - - +<form class="default" action="<?= $controller->action_link('add_dokument', $origin ?? null, $range_type ?? null, $range_id ?? null, $mvvfile_id ?? null) ?>" method="post" data-dialog="size=auto"> + <input type="hidden" name="mvvfile_id" id="mvvfile_id" value="<?= htmlReady($mvvfile_id ?? '') ?>"> + <input type="hidden" name="range_id" id="range_id" value="<?= htmlReady($range_id ?? null) ?>"> + <input type="hidden" name="range_type" id="range_type" value="<?= htmlReady($range_type ?? null) ?>"> <label> <?= _('Jahr') ?> - <input name="doc_year" type="text" value="<?= htmlReady($doc_year) ?>"<?= $perm->disable('year') ?>> + <input name="doc_year" type="text" value="<?= htmlReady($doc_year ?? '') ?>"<?= $perm->disable('year') ?>> </label> - <input type="hidden" name="doc_type" value="<?= $doc_type ?>"> + <input type="hidden" name="doc_type" value="<?= htmlReady($doc_type ?? '') ?>"> <label> <?= _('Art der Datei') ?> <select name="doc_type"<?= $perm->haveFieldPerm('type') ? '' : ' disable' ?>> <? foreach ($GLOBALS['MVV_DOCUMENTS']['TYPE']['values'] as $key => $entry) : ?> - <option value="<?= $key ?>"<?= $key == $doc_type ? ' selected' : '' ?>><?= htmlReady($entry['name']) ?></option> + <option value="<?= htmlReady($key) ?>"<?= isset($doc_type) && $key == $doc_type ? ' selected' : '' ?>> + <?= htmlReady($entry['name']) ?> + </option> <? endforeach; ?> </select> </label> @@ -115,7 +115,9 @@ <?= _('Kategoriezuordnung') ?> <select name="doc_cat"> <? foreach ($GLOBALS['MVV_DOCUMENTS']['CATEGORY']['values'] as $key => $entry) : ?> - <option value="<?= $key ?>"<?= $key == $doc_cat ? ' selected' : '' ?>><?= htmlReady($entry['name']) ?></option> + <option value="<?= htmlReady($key) ?>"<?= isset($doc_cat) && $key == $doc_cat ? ' selected' : '' ?>> + <?= htmlReady($entry['name']) ?> + </option> <? endforeach; ?> </select> </label> @@ -125,13 +127,15 @@ <select id="mvv-files-tags" multiple name="doc_tags[]"> <option value=""></option> <? foreach ($GLOBALS['MVV_DOCUMENTS']['TAG']['values'] as $key => $entry) : ?> - <option value="<?= $key ?>"<?= $key == in_array($key, explode(';', $doc_tags))? ' selected' : '' ?>><?= htmlReady($entry['name']) ?></option> + <option value="<?= htmlReady($key) ?>"<?= $key == in_array($key, explode(';', $doc_tags ?? ''))? ' selected' : '' ?>> + <?= htmlReady($entry['name']) ?> + </option> <? endforeach; ?> </select> </label> <label> - <input name="doc_extvisible" type="checkbox" value="1" <?= $doc_extvisible?'checked':''; ?>> + <input name="doc_extvisible" type="checkbox" value="1" <?= !empty($doc_extvisible) ? 'checked' : '' ?>> <?= _('Sichtbarkeit nach außen') ?> </label> diff --git a/lib/models/AuxLockRule.php b/lib/models/AuxLockRule.php index abd3327bb5fcf4ad2b7f0409e8c5bf95356b8135..f5ebfacee8dd210689aa091bc1e1531e0abf3d0b 100644 --- a/lib/models/AuxLockRule.php +++ b/lib/models/AuxLockRule.php @@ -164,7 +164,7 @@ class AuxLockRule extends SimpleORMap foreach ($this->datafields as $field => $useless_value_pls_refactor) { // if standard get it from the mapping else get it from the datafield - if ($mapping[$field]) { + if (!empty($mapping[$field])) { $result['head'][$field] = $head_mapping[$field]; $new[$field] = htmlReady($mapping[$field]); } else {