From 8cacbaae2dfb8ed402bba58910d03e0556a43ffb Mon Sep 17 00:00:00 2001
From: Jan-Hendrik Willms <tleilax+studip@gmail.com>
Date: Fri, 20 Sep 2024 11:42:06 +0000
Subject: [PATCH] fix another error on studygroup details page, fixes #4622
Closes #4622
Merge request studip/studip!3434
---
app/views/course/studygroup/details.php | 6 +++---
lib/models/Course.php | 2 +-
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/app/views/course/studygroup/details.php b/app/views/course/studygroup/details.php
index 219e6911f9e..26a3ef5bcbc 100644
--- a/app/views/course/studygroup/details.php
+++ b/app/views/course/studygroup/details.php
@@ -20,10 +20,10 @@
<dt><?= _('Moderiert von') ?></dt>
<dd>
<ul class="list-csv">
- <? foreach ($studygroup->getMembers(['dozent', 'tutor']) as $mod) : ?>
+ <? foreach ($studygroup->getMembersWithStatus(['dozent', 'tutor']) as $mod) : ?>
<li>
- <a href="<?= URLHelper::getLink('dispatch.php/profile', ['username' => $mod['username']]) ?>">
- <?= htmlready($mod['fullname']) ?>
+ <a href="<?= URLHelper::getLink('dispatch.php/profile', ['username' => $mod->username]) ?>">
+ <?= htmlReady($mod->user->getFullName()) ?>
</a>
</li>
<? endforeach ?>
diff --git a/lib/models/Course.php b/lib/models/Course.php
index cb94bbc5434..c8475c27e10 100644
--- a/lib/models/Course.php
+++ b/lib/models/Course.php
@@ -924,7 +924,7 @@ class Course extends SimpleORMap implements Range, PrivacyObject, StudipItem, Fe
*
* @param String|Array $status the status to filter with
* @param bool $as_collection return collection instead of array?
- * @return Array|SimpleCollection an array of all those members.
+ * @return CourseMember[]|SimpleCollection an array of all those members.
*/
public function getMembersWithStatus($status, $as_collection = false)
{
--
GitLab