From 872f73b1e19ce32320d9b910bac5759f5b7bc897 Mon Sep 17 00:00:00 2001
From: Jan-Hendrik Willms <tleilax+studip@gmail.com>
Date: Mon, 19 Aug 2024 09:50:30 +0000
Subject: [PATCH] only add valid users as folder creators, fixes #4479
Closes #4479
Merge request studip/studip!3273
---
lib/models/Folder.php | 12 +++++++++++-
1 file changed, 11 insertions(+), 1 deletion(-)
diff --git a/lib/models/Folder.php b/lib/models/Folder.php
index b73571c133f..1c7a13ea49a 100644
--- a/lib/models/Folder.php
+++ b/lib/models/Folder.php
@@ -119,6 +119,16 @@ class Folder extends SimpleORMap implements FeedbackRange
*/
public static function createTopFolder($range_id, $range_type, $folder_type = 'RootFolder')
{
+ $creator_id = User::findCurrent()->id;
+
+ try {
+ $range = RangeFactory::createRange($range_type, $range_id);
+ if (!$range->isEditableByUser()) {
+ $creator_id = '';
+ }
+ } catch (Exception $e) {
+ }
+
return self::create([
'parent_id' => '',
'range_id' => $range_id,
@@ -127,7 +137,7 @@ class Folder extends SimpleORMap implements FeedbackRange
'name' => '',
'data_content' => '',
'folder_type' => $folder_type,
- 'user_id' => $GLOBALS['user']->id
+ 'user_id' => $creator_id,
]);
}
--
GitLab