From 80da8c24da750b580d9f706a7555b9e0617d2a5c Mon Sep 17 00:00:00 2001
From: Jan-Hendrik Willms <tleilax+studip@gmail.com>
Date: Wed, 8 Mar 2023 09:38:30 +0000
Subject: [PATCH] use correct column for progress calculation, fixes #2281
Closes #2281
Merge request studip/studip!1505
---
.../Routes/Courseware/UserProgressesOfUnitsShow.php | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/lib/classes/JsonApi/Routes/Courseware/UserProgressesOfUnitsShow.php b/lib/classes/JsonApi/Routes/Courseware/UserProgressesOfUnitsShow.php
index 1e1745e2cde..e2da5b7a97e 100644
--- a/lib/classes/JsonApi/Routes/Courseware/UserProgressesOfUnitsShow.php
+++ b/lib/classes/JsonApi/Routes/Courseware/UserProgressesOfUnitsShow.php
@@ -95,10 +95,10 @@ class UserProgressesOfUnitsShow extends NonJsonApiController
}
private function getSelfProgresses(
- array &$allBlockIds,
+ array $allBlockIds,
string $elementId,
- array &$userProgresses,
- array &$courseMemberIds
+ array $userProgresses,
+ array $courseMemberIds
): array {
$blks = $allBlockIds[$elementId] ?? [];
if (count($blks) === 0) {
@@ -116,7 +116,7 @@ class UserProgressesOfUnitsShow extends NonJsonApiController
$usersCounter = count($courseMemberIds);
foreach ($blks as $blk) {
$progresses = $userProgresses[$blk];
- $usersProgress = $progresses['count'] ? (float) $progresses['sum'] : 0;
+ $usersProgress = $progresses['count'] ? (float) $progresses['grade'] : 0;
$data['progress'] += $usersProgress / $usersCounter;
}
--
GitLab