From 7355e3c9c0d5fd65b705dfd94ec231f12e379e9a Mon Sep 17 00:00:00 2001
From: Jan-Hendrik Willms <tleilax+studip@gmail.com>
Date: Thu, 24 Oct 2024 08:35:01 +0000
Subject: [PATCH] prevent php8 warning and fix logic, fixes #4757

Closes #4757

Merge request studip/studip!3547
---
 lib/models/Semester.php | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/models/Semester.php b/lib/models/Semester.php
index ca1eaa363ef..ca75dd2d370 100644
--- a/lib/models/Semester.php
+++ b/lib/models/Semester.php
@@ -159,7 +159,7 @@ class Semester extends SimpleORMap
     public static function findAllVisible($with_before_first = true): array
     {
         return array_values(
-            array_filter(self::getAllAsArray(), function ($semester, $key) use($with_before_first) {
+            array_filter(self::getAllAsArray($with_before_first), function ($semester, $key) use($with_before_first) {
                 return $GLOBALS['perm']->have_perm('admin') || !empty($semester['visible']) || ((int)$key === 0 && $with_before_first);
             }, ARRAY_FILTER_USE_BOTH)
         );
-- 
GitLab