From 690fd51ce53f044916bf88a607c63eb17beca0d9 Mon Sep 17 00:00:00 2001
From: David Siegfried <david.siegfried@uni-vechta.de>
Date: Mon, 20 Nov 2023 09:25:48 +0000
Subject: [PATCH] prevent php-warnings, closes #3487

Closes #3487

Merge request studip/studip!2382
---
 app/controllers/siteinfo.php | 16 +++++++++-------
 1 file changed, 9 insertions(+), 7 deletions(-)

diff --git a/app/controllers/siteinfo.php b/app/controllers/siteinfo.php
index 86ab7e7f340..f43826ba4e6 100644
--- a/app/controllers/siteinfo.php
+++ b/app/controllers/siteinfo.php
@@ -96,19 +96,19 @@ class SiteinfoController extends StudipController
     {
         $sidebar = Sidebar::get();
 
-        if (!$GLOBALS['rubrics_empty']) {
+        if (empty($GLOBALS['rubrics_empty'])) {
             $actions = new ActionsWidget();
             $actions->setTitle(_('Seiten-Aktionen'));
 
             if ($this->currentrubric) {
                 $actions->addLink(_('Neue Seite anlegen'),
-                                  $this->url_for('siteinfo/new/' . $this->currentrubric), Icon::create('add', 'clickable'));
+                                  $this->url_for('siteinfo/new/' . $this->currentrubric), Icon::create('add'));
             }
             if ($this->currentdetail) {
                 $actions->addLink(_('Seite bearbeiten'),
-                                  $this->url_for('siteinfo/edit/' . $this->currentrubric . '/' . $this->currentdetail), Icon::create('edit', 'clickable'));
+                                  $this->url_for('siteinfo/edit/' . $this->currentrubric . '/' . $this->currentdetail), Icon::create('edit'));
                 $actions->addLink(_('Seite löschen'),
-                                  $this->url_for('siteinfo/delete/' . $this->currentrubric . '/' . $this->currentdetail), Icon::create('trash', 'clickable'));
+                                  $this->url_for('siteinfo/delete/' . $this->currentrubric . '/' . $this->currentdetail), Icon::create('trash'));
             }
 
             $sidebar->addWidget($actions);
@@ -119,12 +119,12 @@ class SiteinfoController extends StudipController
         $actions->setTitle(_('Rubrik-Aktionen'));
 
         $actions->addLink(_('Neue Rubrik anlegen'),
-                          $this->url_for('siteinfo/new'), Icon::create('add', 'clickable'));
+                          $this->url_for('siteinfo/new'), Icon::create('add'));
         if ($this->currentrubric) {
             $actions->addLink(_('Rubrik bearbeiten'),
-                              $this->url_for('siteinfo/edit/' . $this->currentrubric), Icon::create('edit', 'clickable'));
+                              $this->url_for('siteinfo/edit/' . $this->currentrubric), Icon::create('edit'));
             $actions->addLink(_('Rubrik löschen'),
-                              $this->url_for('siteinfo/delete/' . $this->currentrubric), Icon::create('trash', 'clickable'));
+                              $this->url_for('siteinfo/delete/' . $this->currentrubric), Icon::create('trash'));
         }
 
         $sidebar->addWidget($actions);
@@ -144,6 +144,7 @@ class SiteinfoController extends StudipController
 
     public function new_action($givenrubric = null)
     {
+        $this->edit_rubric = false;
         if ($givenrubric === null) {
             Navigation::addItem('/footer/siteinfo/rubric_new',
                                 new AutoNavigation(_('Neue Rubrik'),
@@ -159,6 +160,7 @@ class SiteinfoController extends StudipController
 
     public function edit_action($givenrubric = null, $givendetail = null)
     {
+        $this->edit_rubric = false;
         if (is_numeric($givendetail)) {
             $this->rubrics      = $this->si->get_all_rubrics();
             $this->rubric_id    = $this->si->rubric_for_detail($this->currentdetail);
-- 
GitLab