From 5c6841c33601a01e0d3c11bd3785437660be3f4b Mon Sep 17 00:00:00 2001
From: David Siegfried <david.siegfried@uni-vechta.de>
Date: Tue, 21 Nov 2023 15:03:24 +0000
Subject: [PATCH] prevent php-warnings, closes #3494
Closes #3494
Merge request studip/studip!2389
---
app/controllers/course/basicdata.php | 9 +++++++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/app/controllers/course/basicdata.php b/app/controllers/course/basicdata.php
index 937ec0f0d02..e0611ed62c8 100644
--- a/app/controllers/course/basicdata.php
+++ b/app/controllers/course/basicdata.php
@@ -490,7 +490,7 @@ class Course_BasicdataController extends AuthenticatedController
} else {
// format of input element name is "course_xxx"
$varname = mb_substr($field['name'], 7);
- if ($field['i18n']) {
+ if (!empty($field['i18n'])) {
$req_value = Request::i18n($field['name']);
} else {
$req_value = Request::get($field['name']);
@@ -528,7 +528,12 @@ class Course_BasicdataController extends AuthenticatedController
$after = array_diff_assoc($sem->getSettings(), $old_settings);
//update admission, if turnout was raised
- if($after['admission_turnout'] > $before['admission_turnout'] && $sem->isAdmissionEnabled()) {
+ if (
+ !empty($after['admission_turnout'])
+ && !empty($before['admission_turnout'])
+ && $after['admission_turnout'] > $before['admission_turnout']
+ && $sem->isAdmissionEnabled()
+ ) {
AdmissionApplication::addMembers($sem->getId());
}
--
GitLab