From 59c6b7f62e2d3d27cd1a4027cd18be5b9a21f64e Mon Sep 17 00:00:00 2001
From: Jan-Hendrik Willms <tleilax+github@gmail.com>
Date: Tue, 7 May 2024 16:04:05 +0200
Subject: [PATCH] re #4128
---
app/views/course/wizard/steps/basicdata/index.php | 2 +-
lib/classes/SemClass.class.php | 12 +++++++-----
2 files changed, 8 insertions(+), 6 deletions(-)
diff --git a/app/views/course/wizard/steps/basicdata/index.php b/app/views/course/wizard/steps/basicdata/index.php
index e1f10a4fde1..f19643a0731 100644
--- a/app/views/course/wizard/steps/basicdata/index.php
+++ b/app/views/course/wizard/steps/basicdata/index.php
@@ -123,7 +123,7 @@
</div>
</section>
-<?php if ($dsearch) : ?>
+<?php if (isset($dsearch)) : ?>
<section>
<label for="deputy_id_3">
<?= _('Vertretungen') ?>
diff --git a/lib/classes/SemClass.class.php b/lib/classes/SemClass.class.php
index c4a2c26cd0f..63be9209155 100644
--- a/lib/classes/SemClass.class.php
+++ b/lib/classes/SemClass.class.php
@@ -304,9 +304,11 @@ class SemClass implements ArrayAccess
public function isModuleAllowed($modulename)
{
return !$this->isModuleForbidden($modulename)
- && (empty($this->data['modules'][$modulename])
- || !$this->data['modules'][$modulename]['sticky']
- || $this->data['modules'][$modulename]['activated']);
+ && (
+ empty($this->data['modules'][$modulename])
+ || empty($this->data['modules'][$modulename]['sticky'])
+ || !empty($this->data['modules'][$modulename]['activated'])
+ );
}
/**
@@ -317,8 +319,8 @@ class SemClass implements ArrayAccess
public function isModuleMandatory($module)
{
return isset($this->data['modules'][$module])
- && $this->data['modules'][$module]['sticky']
- && $this->data['modules'][$module]['activated'];
+ && !empty($this->data['modules'][$module]['sticky'])
+ && !empty($this->data['modules'][$module]['activated']);
}
public function getSemTypes()
--
GitLab