From 4fb7e4cf98b73d334f5ffb7479043b571198f34a Mon Sep 17 00:00:00 2001
From: Jan-Hendrik Willms <tleilax+studip@gmail.com>
Date: Thu, 7 Dec 2023 12:50:15 +0000
Subject: [PATCH] fixes #3544
Closes #3544
Merge request studip/studip!2433
---
app/controllers/course/details.php | 2 +-
lib/models/ModuleManagementModelTreeItem.php | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/app/controllers/course/details.php b/app/controllers/course/details.php
index 2a685e3b683..1c9b0345668 100644
--- a/app/controllers/course/details.php
+++ b/app/controllers/course/details.php
@@ -111,7 +111,7 @@ class Course_DetailsController extends AuthenticatedController
return false;
}
$modul_start = Semester::find($modul->start)->beginn ?: 0;
- $modul_end = Semester::find($modul->end)->ende ?: PHP_INT_MAX;
+ $modul_end = $modul->end ? Semester::find($modul->end)->ende : PHP_INT_MAX;
return ($modul_start <= $course_end && $modul_end >= $course_start);
});
diff --git a/lib/models/ModuleManagementModelTreeItem.php b/lib/models/ModuleManagementModelTreeItem.php
index c2d4269c32b..522a7b05d40 100644
--- a/lib/models/ModuleManagementModelTreeItem.php
+++ b/lib/models/ModuleManagementModelTreeItem.php
@@ -57,7 +57,7 @@ abstract class ModuleManagementModelTreeItem extends ModuleManagementModel imple
$types = $types ?: $path;
$trails = [];
$class_name = get_class($this);
- $next = $path[array_search($class_name, $path) + 1];
+ $next = $path[array_search($class_name, $path) + 1] ?? null;
$parents = $this->getParents($next);
foreach ($parents as $parent) {
--
GitLab