From 3f214ebf27950ab0b204f13996edaf9a43d599b2 Mon Sep 17 00:00:00 2001
From: Jan-Hendrik Willms <tleilax+studip@gmail.com>
Date: Wed, 8 Nov 2023 08:26:01 +0000
Subject: [PATCH] fixes #3430
Closes #3430
Merge request studip/studip!2333
---
lib/classes/JsonApi/Routes/ActivityStreamShow.php | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/lib/classes/JsonApi/Routes/ActivityStreamShow.php b/lib/classes/JsonApi/Routes/ActivityStreamShow.php
index 14470dfdab6..8aa436ce043 100644
--- a/lib/classes/JsonApi/Routes/ActivityStreamShow.php
+++ b/lib/classes/JsonApi/Routes/ActivityStreamShow.php
@@ -16,11 +16,11 @@ use Studip\Activity\UserContext;
function canShowActivityStream(\User $observer, string $userId): bool
{
- if (!$GLOBALS['perm']->have_perm('root', $observer->id)) {
+ if ($GLOBALS['perm']->have_perm('root', $observer->id)) {
return true;
}
- return $observer->id == $userId;
+ return $observer->id === $userId;
}
class ActivityStreamShow extends JsonApiController
@@ -37,12 +37,12 @@ class ActivityStreamShow extends JsonApiController
throw new AuthorizationFailedException();
}
- if (!$user = \User::find($userId)) {
+ $user = \User::find($userId);
+ if (!$user) {
throw new RecordNotFoundException();
}
$urlFilter = $this->getUrlFilter();
- /** @var \User $user */
$contexts = $this->createContexts($user);
$filter = $this->createFilter($urlFilter);
--
GitLab