diff --git a/lib/classes/JsonApi/Routes/ActivityStreamShow.php b/lib/classes/JsonApi/Routes/ActivityStreamShow.php index 14470dfdab64f2b75aaf23ee1c9432970709d0d2..8aa436ce043c929b4bdc88ba52a9fa6eae55d411 100644 --- a/lib/classes/JsonApi/Routes/ActivityStreamShow.php +++ b/lib/classes/JsonApi/Routes/ActivityStreamShow.php @@ -16,11 +16,11 @@ use Studip\Activity\UserContext; function canShowActivityStream(\User $observer, string $userId): bool { - if (!$GLOBALS['perm']->have_perm('root', $observer->id)) { + if ($GLOBALS['perm']->have_perm('root', $observer->id)) { return true; } - return $observer->id == $userId; + return $observer->id === $userId; } class ActivityStreamShow extends JsonApiController @@ -37,12 +37,12 @@ class ActivityStreamShow extends JsonApiController throw new AuthorizationFailedException(); } - if (!$user = \User::find($userId)) { + $user = \User::find($userId); + if (!$user) { throw new RecordNotFoundException(); } $urlFilter = $this->getUrlFilter(); - /** @var \User $user */ $contexts = $this->createContexts($user); $filter = $this->createFilter($urlFilter);